-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(e2e): specify .nyc_output
path as custom config setting
#7658
Conversation
video: 'off' | ||
video: 'off', | ||
// @ts-ignore - custom configuration option for nyc codecoverage output path | ||
coveragePath: fileURLToPath(new URL('../.nyc_output', import.meta.url)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intellisense complains without this since coveragePath is a custom option not a part of the PlaywrightConfig type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎 😎😎
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7658 +/- ##
==========================================
+ Coverage 49.13% 56.32% +7.18%
==========================================
Files 671 672 +1
Lines 27116 27122 +6
Branches 2632 2632
==========================================
+ Hits 13324 15277 +1953
+ Misses 13464 11517 -1947
Partials 328 328
see 211 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Closes #7657
Describe your changes:
Allow specifying the path to output
.nyc_output
raw code coverage *.json in playwright config so we can ensure the e2e coverage is generated against the correct sourcemap pathsAll Submissions:
Author Checklist
type:
label? Note: this is not necessarily the same as the original issue.Reviewer Checklist