Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2e): specify .nyc_output path as custom config setting #7658

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

ozyx
Copy link
Contributor

@ozyx ozyx commented Apr 1, 2024

Closes #7657

Describe your changes:

Allow specifying the path to output .nyc_output raw code coverage *.json in playwright config so we can ensure the e2e coverage is generated against the correct sourcemap paths

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this a notable change that will require a special callout in the release notes? For example, will this break compatibility with existing APIs or projects that consume these plugins?

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Has this been smoke tested?
  • Have you associated this PR with a type: label? Note: this is not necessarily the same as the original issue.
  • Have you associated a milestone with this PR? Note: leave blank if unsure.
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?

@ozyx ozyx added the type:maintenance tests, chores, or project maintenance label Apr 1, 2024
@ozyx ozyx added this to the Target:4.0.0 milestone Apr 1, 2024
@ozyx ozyx requested a review from unlikelyzero April 1, 2024 17:14
video: 'off'
video: 'off',
// @ts-ignore - custom configuration option for nyc codecoverage output path
coveragePath: fileURLToPath(new URL('../.nyc_output', import.meta.url))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intellisense complains without this since coveragePath is a custom option not a part of the PlaywrightConfig type

Copy link
Contributor

@unlikelyzero unlikelyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎 😎😎

@ozyx ozyx added the pr:e2e:couchdb npm run test:e2e:couchdb label Apr 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.32%. Comparing base (f98eb31) to head (64776a8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7658      +/-   ##
==========================================
+ Coverage   49.13%   56.32%   +7.18%     
==========================================
  Files         671      672       +1     
  Lines       27116    27122       +6     
  Branches     2632     2632              
==========================================
+ Hits        13324    15277    +1953     
+ Misses      13464    11517    -1947     
  Partials      328      328              
Flag Coverage Δ
e2e-full 23.64% <ø> (∅)
e2e-stable 60.36% <ø> (?)
unit 49.12% <ø> (-0.02%) ⬇️

see 211 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f98eb31...64776a8. Read the comment docs.

@ozyx ozyx enabled auto-merge (squash) April 1, 2024 18:21
@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Apr 1, 2024
@ozyx ozyx merged commit 311ad0b into master Apr 1, 2024
19 checks passed
@ozyx ozyx deleted the fix-e2e-code-cov branch April 1, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code coverage for e2e tests is busted
3 participants