applying changes made in Edit Properties

src/plugins/telemetryTable/TelemetryTable.js

@@ -114,7 +114,11 @@ export default class TelemetryTable extends EventEmitter {
     this.clearAndResubscribe();
   }
 
-  updateRowLimit() {
+  updateRowLimit(rowLimit) {
+    if (rowLimit) {
+      this.rowLimit = rowLimit;
+    }
+
     if (this.telemetryMode === 'performance') {
       this.tableRows.setLimit(this.rowLimit);
     } else {

src/plugins/telemetryTable/TelemetryTableType.js

@@ -21,7 +21,7 @@
  *****************************************************************************/
 
 export default function getTelemetryTableType(options = {}) {
-  const { telemetryMode = 'performance', persistModeChanges = true, rowLimit = 50 } = options;
+  const { telemetryMode = 'performance', persistModeChange = true, rowLimit = 50 } = options;
 
   return {
     name: 'Telemetry Table',
@@ -51,12 +51,12 @@ export default function getTelemetryTableType(options = {}) {
         name: 'Persist Data Mode Changes',
         control: 'toggleSwitch',
         cssClass: 'l-input',
-        key: 'persistModeChanges',
-        property: ['configuration', 'persistModeChanges']
+        key: 'persistModeChange',
+        property: ['configuration', 'persistModeChange']
       },
       {
         name: 'Limited Data Mode Row Limit',
-        control: 'number',
+        control: 'numberfield',
         cssClass: 'l-input',
         key: 'rowLimit',
         property: ['configuration', 'rowLimit']
@@ -68,7 +68,7 @@ export default function getTelemetryTableType(options = {}) {
         columnWidths: {},
         hiddenColumns: {},
         telemetryMode,
-        persistModeChanges,
+        persistModeChange,
         rowLimit
       };
     }

src/plugins/telemetryTable/components/TableComponent.vue

@@ -398,7 +398,7 @@ export default {
       totalNumberOfRows: 0,
       rowContext: {},
       telemetryMode: configuration.telemetryMode,
-      persistModeChanges: configuration.persistModeChanges,
+      persistModeChange: configuration.persistModeChange,
       afterLoadActions: []
     };
   },
@@ -537,6 +537,8 @@ export default {
     this.table.on('outstanding-requests', this.outstandingRequests);
     this.table.on('telemetry-staleness', this.handleStaleness);
 
+    this.table.configuration.on('change', this.handleConfigurationChanges);
+
     this.table.tableRows.on('add', this.rowsAdded);
     this.table.tableRows.on('remove', this.rowsRemoved);
     this.table.tableRows.on('sort', this.throttledUpdateVisibleRows);
@@ -566,6 +568,8 @@ export default {
     this.table.off('outstanding-requests', this.outstandingRequests);
     this.table.off('telemetry-staleness', this.handleStaleness);
 
+    this.table.configuration.off('change', this.handleConfigurationChanges);
+
     this.table.tableRows.off('add', this.rowsAdded);
     this.table.tableRows.off('remove', this.rowsRemoved);
     this.table.tableRows.off('sort', this.throttledUpdateVisibleRows);
@@ -589,6 +593,26 @@ export default {
         this.afterLoadActions = [];
       }
     },
+    handleConfigurationChanges(changes) {
+      const { rowLimit, telemetryMode, persistModeChange } = changes;
+
+      this.persistModeChange = persistModeChange;
+
+      if (this.rowLimit !== rowLimit) {
+        this.rowLimit = rowLimit;
+        this.table.updateRowLimit(rowLimit);
+
+        if (this.telemetryMode === telemetryMode) {
+          // need to clear and resubscribe, if different, handled below
+          this.table.clearAndResubscribe();
+        }
+      }
+
+      if (this.telemetryMode !== telemetryMode) {
+        this.telemetryMode = telemetryMode;
+        this.table.updateTelemetryMode(telemetryMode);
+      }
+    },
     updateVisibleRows() {
       if (!this.updatingView) {
         this.updatingView = this.renderWhenVisible(() => {
@@ -1187,7 +1211,7 @@ export default {
     updateTelemetryMode() {
       this.telemetryMode = this.telemetryMode === 'unlimited' ? 'performance' : 'unlimited';
 
-      if (this.persistModeChanges) {
+      if (this.persistModeChange) {
         this.table.configuration.setTelemetryMode(this.telemetryMode);
       }