Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New action to reload an individual view and all of its children #7362

Merged
merged 19 commits into from
Jan 25, 2024
Merged

New action to reload an individual view and all of its children #7362

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
b0d83ef
add reload action plugin
scottbell Jan 9, 2024
dfb72b8
checking for domain object before reloading
scottbell Jan 9, 2024
5ed43dd
check if objects are equal before refreshing
scottbell Jan 9, 2024
cfd129c
add test
scottbell Jan 9, 2024
061f4f8
lint
scottbell Jan 9, 2024
e063128
change to label
scottbell Jan 10, 2024
107f15a
Merge branch 'master' into 7343-new-action-to-reload-an-individual-vi…
scottbell Jan 11, 2024
5f2bcb5
ensure object styles are initialized
scottbell Jan 11, 2024
f103afc
resubscribe to staleness too
scottbell Jan 11, 2024
89a824e
add better labels for tabels
scottbell Jan 11, 2024
af84a6e
ensure tab uses exact for label now due to table aria changes
scottbell Jan 11, 2024
1f34ab5
fix table tests
scottbell Jan 11, 2024
e64bafe
make tabs exact
scottbell Jan 11, 2024
211bc31
Merge branch 'master' into 7343-new-action-to-reload-an-individual-vi…
scottbell Jan 16, 2024
b8bae55
update conflicts
scottbell Jan 16, 2024
b27a6a4
Merge branch 'master' into 7343-new-action-to-reload-an-individual-vi…
scottbell Jan 18, 2024
ba62590
Merge branch 'master' into 7343-new-action-to-reload-an-individual-vi…
ozyx Jan 19, 2024
8a606a5
Merge branch 'master' into 7343-new-action-to-reload-an-individual-vi…
scottbell Jan 23, 2024
4e8ac13
Merge branch 'master' into 7343-new-action-to-reload-an-individual-vi…
unlikelyzero Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
resubscribe to staleness too
  • Loading branch information
@scottbell
scottbell committed Jan 11, 2024
commit f103afc77d5d72e145e9fe3d26b83c89b7d0a566
4 changes: 2 additions & 2 deletions src/ui/components/ObjectView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,10 +221,10 @@
this.updateView(true);
},
reload(domainObjectToReload) {
if (objectUtils.equals(domainObjectToReload, this.domainObject)) {

Check warning on line 224 in src/ui/components/ObjectView.vue

View check run for this annotation

Codecov / codecov/patch

src/ui/components/ObjectView.vue#L224 

Added line #L224 was not covered by tests
this.clear();
this.initObjectStyles();
this.updateView(true);
this.initObjectStyles();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

this.triggerStalenessSubscribe(this.domainObject);
}
},
triggerStalenessSubscribe(object) {
Expand Down
Loading