Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set location hash if query parameters or path have changed #7306

Merged
merged 24 commits into from
Jan 8, 2024
Merged

Set location hash if query parameters or path have changed #7306

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
c983828
refactor to es6 class
scottbell Dec 15, 2023
9dacd53
Merge remote-tracking branch 'origin/master' into 7303-url-not-updati…
scottbell Dec 16, 2023
6179690
change URL on path or params change
scottbell Dec 16, 2023
e78c907
add test for url
scottbell Dec 16, 2023
c04cdad
put into edit mode for test
scottbell Dec 16, 2023
45ae431
Merge branch 'master' into 7303-url-not-updating-when-navigating-to-o…
scottbell Dec 19, 2023
a7f6046
Merge branch 'master' into 7303-url-not-updating-when-navigating-to-o…
scottbell Dec 19, 2023
aacb689
es6 module export
scottbell Dec 19, 2023
d279306
Merge branch 'master' into 7303-url-not-updating-when-navigating-to-o…
scottbell Dec 20, 2023
96b9ec3
Merge branch 'master' into 7303-url-not-updating-when-navigating-to-o…
scottbell Dec 22, 2023
e4afaaa
Merge branch 'master' into 7303-url-not-updating-when-navigating-to-o…
ozyx Jan 2, 2024
76d5db8
a11y: add `status` role to clock component
ozyx Jan 3, 2024
1c9f616
a11y: add label to overlay
ozyx Jan 3, 2024
2ba8133
a11y: update roles for search results
ozyx Jan 3, 2024
f1784ba
a11y: add `dialog` role and label for PreviewContainer
ozyx Jan 3, 2024
f84d3fd
refactor(e2e): get rid of a bunch of `page.locator()`s
ozyx Jan 3, 2024
acddf74
Merge branch 'master' into 7303-url-not-updating-when-navigating-to-o…
ozyx Jan 3, 2024
919ee5d
refactor(e2e): spruce up locators
ozyx Jan 3, 2024
2a07bc9
test: fix unit tests
ozyx Jan 3, 2024
ae6819b
Merge branch 'master' into 7303-url-not-updating-when-navigating-to-o…
scottbell Jan 4, 2024
d2a450b
fix tests with new aria labels
scottbell Jan 8, 2024
8bc15e9
fix tests with new aria labels
scottbell Jan 8, 2024
817fb03
fix tests with new aria labels
scottbell Jan 8, 2024
9f8dd2d
Merge branch 'master' into 7303-url-not-updating-when-navigating-to-o…
scottbell Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests with new aria labels
  • Loading branch information
@scottbell
scottbell committed Jan 8, 2024
commit 817fb03d0aa278550668e39bf69a04811048b1fc
4 changes: 1 addition & 3 deletions e2e/tests/functional/search.e2e.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,9 +218,7 @@ test.describe('Grand Search', () => {
// 1. batched request for latest telemetry using the bulk API
expect(networkRequests.length).toBe(1);

await expect(page.locator('[aria-label="Object Search Result"]').first()).toContainText(
'Clock A'
);
await expect(page.getByRole('list', { name: 'Object Results' })).toContainText('Clock A');
});

test('Slowly typing after search debounce will abort requests @couchdb', async ({ page }) => {
Expand Down
Loading