Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Update docker login step to work across forks and non-nasa-users #6891

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

unlikelyzero
Copy link
Contributor

Closes #6890

Describe your changes:

Continues on error for the docker login step which only caches the images. This should only mean that PRs for users are about 30s slower

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Is this change backwards compatible? For example, developers won't need to change how they are calling the API or how they've extended core plugins such as Tables or Plots.

Author Checklist

  • Changes address original issue?
  • Tests included and/or updated with changes?
  • Command line build passes?
  • Has this been smoke tested?
  • Testing instructions included in associated issue OR is this a dependency/testcase change?

Reviewer Checklist

  • Changes appear to address issue?
  • Reviewer has tested changes by following the provided instructions?
  • Changes appear not to be breaking changes?
  • Appropriate automated tests included?
  • Code style and in-line documentation are appropriate?
  • Has associated issue been labelled unverified? (only applicable if this PR closes the issue)
  • Has associated issue been labelled bug? (only applicable if this PR is for a bug fix)

@unlikelyzero unlikelyzero added the type:maintenance tests, chores, or project maintenance label Aug 4, 2023
@unlikelyzero unlikelyzero added this to the Target:3.1.0 milestone Aug 4, 2023
@unlikelyzero unlikelyzero added the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 4, 2023
@deploysentinel
Copy link

deploysentinel bot commented Aug 4, 2023

Current Playwright Test Results Summary

✅ 134 Passing - ⚠️ 3 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/05/2023 08:41:18pm UTC)

Run Details

Running Job e2e-stable on CircleCI

Commit: f7b20e7

Started: 08/05/2023 08:36:00pm UTC

⚠️ Flakes

📄   functional/plugins/conditionSet/conditionSet.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Basic Condition Set Use ConditionSet should output blank instead of the default value
Retry 1Initial Attempt
11.21% (12) 12 / 107 runs
failed over last 7 days
39.25% (42) 42 / 107 runs
flaked over last 7 days

📄   functional/plugins/notebook/restrictedNotebook.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Restricted Notebook with a page locked and with an embed @addinit Disallows embeds to be deleted if page locked @addinit
Retry 1Initial Attempt
0% (0) 0 / 85 runs
failed over last 7 days
23.53% (20) 20 / 85 runs
flaked over last 7 days

📄   functional/plugins/flexibleLayout/flexibleLayout.e2e.spec.js • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Flexible Layout independent time works with flexible layouts and its children
Retry 2Retry 1Initial Attempt
5.15% (5) 5 / 97 runs
failed over last 7 days
6.19% (6) 6 / 97 runs
flaked over last 7 days

View Detailed Build Results


Current Playwright Test Results Summary

✅ 14 Passing

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/05/2023 08:41:18pm UTC)

Run Details

Running Workflow e2e-couchdb on Github Actions

Commit: f7b20e7

Started: 08/04/2023 11:00:00pm UTC

View Detailed Build Results


@github-actions github-actions bot removed the pr:e2e:couchdb npm run test:e2e:couchdb label Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #6891 (f7b20e7) into master (ee6ca11) will decrease coverage by 0.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #6891      +/-   ##
==========================================
- Coverage   48.87%   48.41%   -0.47%     
==========================================
  Files         644      644              
  Lines       25628    25628              
  Branches     2496     2496              
==========================================
- Hits        12525    12407     -118     
- Misses      12618    12747     +129     
+ Partials      485      474      -11     
Flag Coverage Δ *Carryforward flag
e2e-full 42.03% <ø> (-0.01%) ⬇️ Carriedforward from ee6ca11
e2e-stable 57.20% <ø> (+0.05%) ⬆️
unit 38.79% <ø> (-0.83%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee6ca11...f7b20e7. Read the comment docs.

@unlikelyzero unlikelyzero merged commit 4287cd5 into master Aug 5, 2023
@unlikelyzero unlikelyzero deleted the couchdb-continue-on-error branch August 5, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:maintenance tests, chores, or project maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Update docker login step to work across forks and non-nasa-users
2 participants