Repository navigation
Add parameter validation macro - #5670
Conversation
|
@bocchino This implements #5573 and is ready for maintainer review. GitHub is holding the Actions workflows for first-time-contributor approval; please approve the runs when convenient. The branch is current with |
|
This PR is addressing an issue that has been approved for development by the CCB. We welcome this PR to be reopened if and when the CCB approves the issue. |
|
This was approved by the CCB! |
8bbe562 to
f391264
Compare
|
Thanks @LeStarch for confirming the CCB approval and reopening this. I rebased the contribution cleanly onto current
@bocchino, this is ready for maintainer review. GitHub currently shows no check runs on the new head, so the first-time-contributor workflows still need maintainer approval before the automated gates can report. |
Change Description
Add
FW_PARAM_OK, a shared macro that reports whether anFw::ParamValidvalue isVALIDorDEFAULT. Replace the existing equivalent checks throughout the framework and service components, and add unit coverage for all four parameter-validity states.Rationale
Parameter consumers repeatedly spell out the same validity condition. Centralizing it removes boilerplate and gives parameter checks one consistent expression.
Testing/Review Recommendations
fprime-util format --checkon all changed C++ filesfprime-util check --all(129/129 tests passed)FW_PARAM_OKaccepts onlyVALIDandDEFAULTFuture Work
None.
AI Usage (see policy)
OpenAI Codex was used to inspect the issue and repository, implement the macro and unit test, refactor existing checks, run formatting and the full test suite, and prepare this pull request. The submitted code and prose were generated by the AI agent and validated against the repository's pinned toolchain.
IAMAI