Fix #58, Replace ctime with ctime_r #59
Conversation
| { | ||
| int RtnCode; | ||
| int RtnCode; | ||
| char TimeBuff[50]; |
There was a problem hiding this comment.
Do we have a buffer size macro?
There was a problem hiding this comment.
Nothing I could find built in. Documentation says a minimum of 26. I'll just get truncated (and it's just an info message) so I didn't think it was worth any additional effort. If you'd prefer we could just delete the message.
There was a problem hiding this comment.
The maximum is locality based, which is likely why it's not defined since a locality could be added that requires more space.
There was a problem hiding this comment.
Let's leave it, though I wonder if we might want to define something using cmake in the future
There was a problem hiding this comment.
I don't consider it a configuration parameter. Macro is fine but I wouldn't expose it outside this unit.
|
CCB 2020-08-26 - APPROVED, @ArielSAdamsNASA take another look |
4 participants
Describe the contribution
Fix #58 - replace ctime (which generates LGTM warning) with ctime_r
Testing performed
Built and ran code in verbose mode, confirmed time output
Expected behavior changes
Eliminate LGTM warning
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC