Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-10151: Add Collection Search Endpoint #349

Merged
merged 6 commits into from
Sep 25, 2024
Merged

CMR-10151: Add Collection Search Endpoint #349

merged 6 commits into from
Sep 25, 2024

Conversation

dmistry1
Copy link
Collaborator

Adding support for collection-search:

  • Adds collection search extension to conformsTo

  • Initially, I considered adding a /collections/search route for searching collections. While this is a valid approach, it's more aligned with STAC browser to implement collection search directly at the /collections level. (see discussion here).

  • A user can now search for collection based on spatial and temporal fields.

  • In STAC browser there is now a Search for Collections tab
    image

  • Collection Search though a CURL

    • GET: curl "http://localhost:3000/stac/LPCLOUD/collections?bbox=-180,-90,180,90"
    • POST : curl -X POST "http://localhost:3000/stac/PROVIDER_ID/collections" \ -H "Content-Type: application/json" \ -d `{ "bbox": [-180, -90, 180, 90], "datetime": "2021-01-01T00:00:00Z/2021-12-31T23:59:59Z", "limit": 10}'

@eudoroolivares2016 eudoroolivares2016 changed the title CMR:10151: Add Collection Search Endpoint CMR-10151: Add Collection Search Endpoint Sep 23, 2024
@dmistry1 dmistry1 requested a review from abbottry September 23, 2024 20:57
Copy link
Contributor

@william-valencia william-valencia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test that does the POST request for the collection search?

@william-valencia
Copy link
Contributor

Also looks like there is a snyk vulnerability that needs to be addressed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.56%. Comparing base (b3b24cf) to head (9b1b24e).
Report is 70 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
- Coverage   88.77%   87.56%   -1.22%     
==========================================
  Files          29       23       -6     
  Lines        1515     1094     -421     
  Branches      298      238      -60     
==========================================
- Hits         1345      958     -387     
+ Misses        161      136      -25     
+ Partials        9        0       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmistry1 dmistry1 merged commit 4cc405c into master Sep 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants