Skip to content

Conversation

@ArielSAdamsNASA
Copy link
Contributor

@ArielSAdamsNASA ArielSAdamsNASA commented Oct 8, 2021

Checklist (Please check before submitting)

Describe the contribution
Fixes #372

Testing performed
Tested on fork, https://github.com/ArielSAdamsNASA/cFS-JSF-Rules/runs/3872860265?check_suite_focus=true

Expected behavior changes
Same results as before, just different way of locating queries.

Remove

      - name: Checkout codeql code      
        if: ${{ !steps.skip-workflow.outputs.skip }}
        uses: actions/checkout@v2
        with:
          repository: github/codeql 
          submodules: true 
          path: codeql

CodeQL is already checked out when using CodeQL Actions.

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal

@ArielSAdamsNASA ArielSAdamsNASA force-pushed the fix-372-codeql-query-suites branch from 2443e54 to 4d4b08d Compare October 12, 2021 16:17
@ArielSAdamsNASA ArielSAdamsNASA added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Oct 12, 2021
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Oct 13, 2021
@astrogeco
Copy link
Contributor

CCB:2021-10-13 APPROVED

@astrogeco
Copy link
Contributor

@ArielSAdams does this affect the CodeQL runs in cFE and other submodules?

@ArielSAdamsNASA
Copy link
Contributor Author

ArielSAdamsNASA commented Oct 18, 2021

@ArielSAdams does this affect the CodeQL runs in cFE and other submodules?

@astrogeco Yes. cFE and the other submodules also uses the new query suite.

@astrogeco
Copy link
Contributor

@ArielSAdams does this affect the CodeQL runs in cFE and other submodules?

@astrogeco Yes. cFE and the other submodules also uses the new query suite.

Do we need other PRs on those or will this be transparent to the other submodules?

@ArielSAdamsNASA
Copy link
Contributor Author

@ArielSAdams does this affect the CodeQL runs in cFE and other submodules?

@astrogeco Yes. cFE and the other submodules also uses the new query suite.

Do we need other PRs on those or will this be transparent to the other submodules?

@astrogeco I don't believe we need PRs. cFE and the other submodule workflows references the configuration file from cFS, which references the query suite file.

@astrogeco astrogeco changed the base branch from main to integration-candidate October 18, 2021 17:02
@astrogeco astrogeco merged commit 9288ea4 into nasa:integration-candidate Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CCB:Approved Indicates code review and approval by community CCB continuous-integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CodeQL Query Suites

3 participants