Fix #272, Apply fix for Osal guide pdf generation

[nmullane]

Checklist (Please check before submitting)

• I reviewed the Contributing Guide.
• I signed and emailed the appropriate Contributor License agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.

Describe the contribution

• Modified build-documentation.yml to fix GitHub action workflow fails to generate Osal guide pdf #272 and successfully generate the Osal guide pdf in the documentation GitHub Actions workflow

Testing performed
Steps taken to test the contribution:

1. Modified the if statements in build-documentation.yml to force the Osal pdf to generate on my forked branch to ensure the fix worked properly. The output of this GitHub Actions Documentation workflow run is here
2. The change to the if statements was reverted and a GitHub Actions Documentation worfklow run without this modification is here

Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.

• Changed a single cd command in build-documentation.yml which should let the subsequent make call run properly
• No expected behavior should change. This only fixes an issue with the Osal guide not being generated by GitHub Actions.

System(s) tested on

• GitHub actions ubuntu-18.04 runner

Code contributions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.

Contributor Info - All information REQUIRED for consideration of pull request
Niall Mullane, GSFC Code 582 intern

[astrogeco]

CCB:2021-06-23, APPROVED

• double check that the cFE pdf is also being published

[skliper]

@astrogeco I don't see updated pdfs https://github.com/nasa/cFS/tree/gh-pages. Still broken?

[astrogeco]

yep, "check for duplicates" is preventing this from running for the push job. Will need to modify the workflow