Skip to content

GitHub Actions Shell Injection #1029

@arielswalker

Description

@arielswalker

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the cFS README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
There are multiple locations where ${{ ... }} expressions are interpolated directly inside run:. These values are then interpreted by the shell expressions. Impact includes arbitrary command execution in CI, build/artifact tampering.

Describe the solution you'd like
Replace all ${{ ... }} expression in run: steps with environment variables.

Describe alternatives you've considered
Keep as is.

Additional context
Should be updated in cFS, EdsLib, cFE, and OSAL. There may be additional repositories that need to be updated.

Requester Info
Ariel Walker, MCSG TECH.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions