Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Candidate COMBINED 2020-04-29 and 2020-05-06 #692

Merged
merged 36 commits into from
May 13, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
4dd5bda
Fix #637, Remove old CFE_ARINC653-related tests
lethuillierg Apr 24, 2020
cff18ab
Fix #641, string operations on GCC9
jphickey Apr 27, 2020
a3230cb
Fix #484, Deprecate output to shell command
skliper Apr 27, 2020
f211a06
Fix #523, SB Subscription report control on separate MID
skliper Apr 28, 2020
48d7a11
Fix #551, Remove duplicate CFE_TIME_Local1HzISR prototype
skliper May 5, 2020
aa94b2e
fix #661 - TBL events update
CDKnightNASA May 5, 2020
306f286
Fix #519, Deprecate CFS/FS time conversion APIs
skliper May 5, 2020
8642f8a
Fix #618, stubs must not depend on real msgid implementation
jphickey May 5, 2020
d4f62ed
Fix #411, rework exception handling in CFE
jphickey Apr 29, 2020
87b87c8
Update #411, documentation updates
jphickey May 6, 2020
7c17fd8
Fix #676, reference to deprecated CFE_SPACECRAFT_ID
jphickey May 6, 2020
4908b72
Issue #666, Define aligned message headers
jphickey May 6, 2020
5e71fe2
Issue #666, Change message definitions to ensure alignment
jphickey May 6, 2020
b3a9974
Merge pull request #640 from lethuillierg/issue_637
astrogeco May 8, 2020
d30c229
Merge pull request #645 from skliper/fix484-exec-in-shell
astrogeco May 8, 2020
0f363dd
Merge pull request #642 from jphickey/fix-641-stringops
astrogeco May 8, 2020
159ab75
Merge pull request #647 from skliper/fix523-sb-sub-rpt-mid
astrogeco May 8, 2020
532c0dc
Merge pull request #668 from skliper/fix551-dup-local1hzisr-proto
astrogeco May 8, 2020
492664b
Merge pull request #677 from jphickey/fix-676-fix-deprecated-symbol
astrogeco May 8, 2020
2a0494e
Issue #666, Change message definitions to ensure alignment
jphickey May 6, 2020
733eb94
Merge pull request #653 from jphickey/fix-411-exceptions
astrogeco May 8, 2020
1d99380
Merge pull request #678 from jphickey/fix-666-sb-message-alignment
astrogeco May 8, 2020
d2c54cc
Merge pull request #674 from jphickey/fix-618-stub-msgid-dependency
astrogeco May 8, 2020
fd802f3
Merge pull request #669 from CDKnightNASA/fix-661-tbl_events_fix
astrogeco May 8, 2020
4c392cc
Merge pull request #670 from skliper/fix#519-dep-fstime-conversions
astrogeco May 8, 2020
9cb0b5d
Fix #639, Remove ES_APP_DEBUG functionality
skliper Apr 28, 2020
56e024c
Fix #399, Deprecate decompress
skliper Apr 24, 2020
b58ff99
Fix #559, Resolve doxygen warnings
skliper May 8, 2020
99f670b
Merge pull request #646 from skliper/fix639-es-app-debug
skliper May 11, 2020
4102f47
Merge pull request #638 from skliper/fix399-decompress-untraced
skliper May 11, 2020
c8d8bf8
Merge pull request #648 from lbleier-GSFC/fix559-fixdocwarnings
skliper May 11, 2020
7b56b85
HOTFIX: Remove dprecated CFE_FS_IsGzFile test
skliper May 11, 2020
6f06b16
HOTFIX: Update to #674, use metadata for packet length.
jphickey May 11, 2020
5b66886
Fix #491, Add UT macros
skliper May 11, 2020
7622827
Merge pull request #695 from skliper/fix491-ut-macros
skliper May 11, 2020
f89193f
Increase version to 6.7.17, update Readme and tidy-up markdown.
astrogeco May 13, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 0 additions & 173 deletions fsw/cfe-core/unit-test/es_UT.c
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ extern CFE_ES_CDSBlockDesc_t CFE_ES_CDSBlockDesc;
extern CFE_ES_TaskData_t CFE_ES_TaskData;
extern CFE_ES_CDSPool_t CFE_ES_CDSMemPool;

#ifdef CFE_ARINC653
extern CFE_ES_StaticStartupTable_t CFE_ES_StaticStartupTable[];
#endif

extern int32 dummy_function(void);

/*
Expand Down Expand Up @@ -295,10 +291,6 @@ void UtTest_Setup(void)
UT_ADD_TEST(TestESMempool);
UT_ADD_TEST(TestSysLog);
UT_ADD_TEST(TestBackground);

#ifdef CFE_ARINC653
UT_ADD_TEST(TestStaticApp);
#endif
}

/*
Expand Down Expand Up @@ -7040,168 +7032,3 @@ void TestBackground(void)
"CFE_ES_BackgroundTask - Nominal, CFE_ES_Global.BackgroundTask.NumJobsRunning (%u) == 1",
(unsigned int)CFE_ES_Global.BackgroundTask.NumJobsRunning);
}



#ifdef CFE_ARINC653
void TestStaticApp(void)
{
int j;
uint32 Id;
uint32 LibraryIdPtr;
CFE_ES_AppMainFuncPtr_t MainFunc = 0;

/* Test successful static app creation */
ES_ResetUnitTest();
CFE_ES_Global.AppTable[0].AppState = CFE_ES_AppState_RUNNING;
CFE_ES_Global.AppTable[1].AppState = CFE_ES_AppState_UNDEFINED;
CFE_ES_Global.TaskTable[1].RecordUsed = false;
UT_Report(__FILE__, __LINE__,
CFE_ES_StaticAppCreate(&Id,
MainFunc,
"AppName",
170,
4096,
1) == CFE_SUCCESS &&
CFE_ES_Global.TaskTable[1].RecordUsed == true,
"CFE_ES_StaticAppCreate",
"Create static application; successful");

/* Test static app creation with a task create failure */
ES_ResetUnitTest();
UT_SetForceFail(UT_KEY(OS_TaskCreate), OS_ERROR);
UT_Report(__FILE__, __LINE__,
CFE_ES_StaticAppCreate(&Id,
MainFunc,
"AppName",
170,
4096,
1) == CFE_ES_ERR_APP_CREATE,
"CFE_ES_StaticAppCreate",
"Task create error");

/* Test static app creation specifying a slot already in use */
ES_ResetUnitTest();
CFE_ES_Global.TaskTable[0].RecordUsed = true;
UT_Report(__FILE__, __LINE__,
CFE_ES_StaticAppCreate(&Id,
MainFunc,
"AppName",
170,
4096,
1) == CFE_SUCCESS,
"CFE_ES_StaticAppCreate",
"Task slot in use");

/* Test static app creation with no free slots available */
ES_ResetUnitTest();

for (j = 0; j < CFE_PLATFORM_ES_MAX_APPLICATIONS; j++)
{
CFE_ES_Global.AppTable[j].AppState = CFE_ES_AppState_RUNNING;
}

UT_Report(__FILE__, __LINE__,
CFE_ES_StaticAppCreate(&Id,
MainFunc,
"AppName",
170,
4096,
1) == CFE_ES_ERR_APP_CREATE,
"CFE_ES_StaticAppCreate",
"No free application slots available");

/* Test successful static shared library initialization */
ES_ResetUnitTest();
UT_SetLibInitRtn(CFE_SUCCESS);
LibraryIdPtr = 1;
CFE_ES_Global.LibTable[0].RecordUsed = false;
UT_Report(__FILE__, __LINE__,
CFE_ES_InitStaticLibrary(&LibraryIdPtr,
(CFE_ES_LibInitFuncPtr_t) UT_LibInit,
"LibName") == CFE_SUCCESS &&
LibraryIdPtr == 0,
"CFE_ES_InitStaticLibrary",
"Static library initialization; successful");

/* Test static shared library initialization with a library load failure */
ES_ResetUnitTest();
UT_SetLibInitRtn(CFE_ES_ERR_LOAD_LIB);
CFE_ES_Global.LibTable[0].RecordUsed = false;
UT_Report(__FILE__, __LINE__,
CFE_ES_InitStaticLibrary(&LibraryIdPtr,
(CFE_ES_LibInitFuncPtr_t) UT_LibInit,
"LibName") == CFE_ES_ERR_LOAD_LIB,
"CFE_ES_InitStaticLibrary",
"Shared library initialization failure");

/* Test static shared library initialization with no free
* slots available
*/
ES_ResetUnitTest();

for (j = 0; j < CFE_PLATFORM_ES_MAX_LIBRARIES; j++)
{
CFE_ES_Global.LibTable[j].RecordUsed = true;
}

UT_Report(__FILE__, __LINE__,
CFE_ES_InitStaticLibrary(&LibraryIdPtr,
(CFE_ES_LibInitFuncPtr_t) UT_LibInit,
"LibName") == CFE_ES_ERR_LOAD_LIB,
"CFE_ES_InitStaticLibrary",
"No free library slots available");

/* Test successful static application initialization */
ES_ResetUnitTest();

for (j = 0; j < CFE_PLATFORM_ES_MAX_LIBRARIES; j++)
{
CFE_ES_Global.LibTable[j].RecordUsed = false;
}

strncpy(CFE_ES_StaticStartupTable[0].Name,
"StaticAppName", OS_MAX_API_NAME);
CFE_ES_StaticStartupTable[0].Name[OS_MAX_API_NAME - 1] = '\0';
CFE_ES_StaticStartupTable[0].ObjectType = CFE_ES_STATIC_APP;
CFE_ES_StaticStartupTable[0].ExceptionAction =
CFE_ES_ExceptionAction_RESTART_APP + 1;
CFE_ES_StartStaticApplications(CFE_PSP_RST_TYPE_PROCESSOR);
UT_Report(__FILE__, __LINE__,
CFE_ES_StaticStartupTable[0].ExceptionAction ==
CFE_ES_ExceptionAction_PROC_RESTART &&
UT_PrintfIsInHistory(UT_OSP_MESSAGES[UT_OSP_NO_MESSAGE]),
"CFE_ES_StartStaticApplications",
"*Not implemented* Initialize static application; successful");

/* Test successful static library initialization */
ES_ResetUnitTest();
CFE_ES_StaticStartupTable[0].ObjectType = CFE_ES_STATIC_LIB;
CFE_ES_StartStaticApplications(CFE_PSP_RST_TYPE_PROCESSOR);
UT_Report(__FILE__, __LINE__,
UT_PrintfIsInHistory(UT_OSP_MESSAGES[UT_OSP_NO_MESSAGE]),
"CFE_ES_StartStaticApplications",
"*Not implemented* Initialize static shared library; successful");

/* Test successful static application initialization null action */
ES_ResetUnitTest();
CFE_ES_StaticStartupTable[0].ObjectType = CFE_ES_STATIC_NULL;
CFE_ES_StartStaticApplications(CFE_PSP_RST_TYPE_PROCESSOR);
UT_Report(__FILE__, __LINE__,
UT_PrintfIsInHistory(UT_OSP_MESSAGES[UT_OSP_NO_MESSAGE]),
"CFE_ES_StartStaticApplications",
"*Not implemented* No action");

/* Test successful static library initialization with an invalid
* entry type
*/
ES_ResetUnitTest();
CFE_ES_StaticStartupTable[0].ObjectType = 0xff;
CFE_ES_StartStaticApplications(CFE_PSP_RST_TYPE_PROCESSOR);
UT_Report(__FILE__, __LINE__,
UT_PrintfIsInHistory(UT_OSP_MESSAGES[UT_OSP_NO_MESSAGE]),
"CFE_ES_StartStaticApplications",
"*Not implemented* Unexpected entry type");
}
#endif

25 changes: 0 additions & 25 deletions fsw/cfe-core/unit-test/es_UT.h
Original file line number Diff line number Diff line change
Expand Up @@ -355,29 +355,4 @@ void TestESMempool(void);

void TestSysLog(void);

#ifdef CFE_ARINC653
/*****************************************************************************/
/**
** \brief Perform tests on the cFE applications from statically linked code
**
** \par Description
** This function tests the code for creating and loading cFE
** applications from statically linked code, and for initializing
** static libraries.
**
** \par Assumptions, External Events, and Notes:
** None
**
** \returns
** This function does not return a value.
**
** \sa #UT_InitData, #UT_Report, CFE_ES_StaticAppCreate, #UT_SetOSFail
** \sa #UT_SetLibInitRtn, #CFE_ES_InitStaticLibrary
** \sa #CFE_ES_StartStaticApplications
**
******************************************************************************/
void TestStaticApp(void);
#endif


#endif /* _es_ut_h_ */