Integration candidate 2019-10-09 #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure consistency in the size of the CFE_TBL_FileHdr_t struct, this should be constrained to use only mission-scope definitions. Also simplifies the structure definitions by _NOT_ padding strings out to 32 bit multiples. The default size of the strings are already 32 bit multiples so this is just unnecessary complexity. There is also no major issue if not 32 bit aligned, as the compiler will add it automatically where needed. Add a note in the related cfe_mission_cfg.h descriptions to affected values, that these should be kept as a multiple of 4 to maintain alignment. Updated for 2019-09-16 code review: - Added compile-time verification that the configuration directives are actually multiples of 4.
|
Re-validated branch by re-building, executing unit tests, and sanity check of CFE core execution. All looks fine. |
skliper
added
the
CCB:Approved
|
CCB 20191023 - Reviewed and approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Integration candidate for pull requests approved at 2019-10-09 CCB
Covers the following pull requests:
#27 - Ensure table naming consistent across CPUs
#367 - Fix infinite loop when gz file is truncated
#369 - Update obj creation failure requirement
Testing performed
Build code for native host (SIMULATION=native) with unit test enabled
Execute CFE core, issued various test commands from cmdUtil
Execute all unit tests and confirm passage.
Expected behavior changes
None
System(s) tested on:
Ubuntu 18.04.2 LTS 64-bit
Additional context
NA
Contributor Info
Joseph Hickey, Vantage Systems, Inc.