Fix #2618, Correct syntax for variable APP_NAME in arch_build.cmake #2619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jphickey
approved these changes
Nov 14, 2025
Contributor
jphickey
left a comment
jphickey
left a comment
There was a problem hiding this comment.
Looks good. The APP_NAME mistake is OBE with the upcoming release but the other fixup is needed.
jphickey
added
the
CCB:Ready
thnkslprpt
force-pushed
the
fix-2618-correct-arch-build-cmake
branch
from
56ba5dd to
0ede871
Compare
Contributor
Author
|
Rebased to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
APP_NAMEto be referenced using braces instead of parenthesesTesting performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
Expected behavior changes
Correct CMake syntax - I'm actually not sure if this worked somehow anyway beforehand or not.
System(s) tested on
Debian 12 using the current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt