Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2530, naming convention for SendHkCmd #2531

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

jphickey
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Corrects name mismatches in the "SendHkCmd" implementations. ES, EVS, and TBL modules had variations on what this command was named internally in the code.

Fixes #2530

Testing performed
Run all tests

Expected behavior changes
None

System(s) tested on
Debain

Additional context
In the main line build this is just for code consistency and pattern compliance, as this name isn't exposed externally. It does, however, start to matter when using generated header files.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Corrects name mismatches in the "SendHkCmd" implementations.
ES, EVS, and TBL modules had variations on what this command
was named internally in the code.
@@ -443,7 +443,7 @@
* See description in header file for argument/return detail
*
*-----------------------------------------------------------------*/
int32 CFE_ES_HousekeepingCmd(const CFE_ES_SendHkCmd_t *data)
int32 CFE_ES_SendHkCmd(const CFE_ES_SendHkCmd_t *data)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@@ -338,7 +338,7 @@
* See description in header file for argument/return detail
*
*-----------------------------------------------------------------*/
int32 CFE_EVS_ReportHousekeepingCmd(const CFE_EVS_SendHkCmd_t *data)
int32 CFE_EVS_SendHkCmd(const CFE_EVS_SendHkCmd_t *data)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@@ -42,7 +42,7 @@
* See description in header file for argument/return detail
*
*-----------------------------------------------------------------*/
int32 CFE_TBL_HousekeepingCmd(const CFE_MSG_CommandHeader_t *data)
int32 CFE_TBL_SendHkCmd(const CFE_TBL_SendHkCmd_t *data)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@@ -1319,7 +1319,7 @@
/*
** Test the function that processes housekeeping request message
*/
void Test_CFE_TBL_HousekeepingCmd(void)
void Test_CFE_TBL_SendHkCmd(void)

Check notice

Code scanning / CodeQL

Long function without assertion Note

All functions of more than 10 lines should have at least one assertion.
@@ -443,7 +443,7 @@
* See description in header file for argument/return detail
*
*-----------------------------------------------------------------*/
int32 CFE_ES_HousekeepingCmd(const CFE_ES_SendHkCmd_t *data)
int32 CFE_ES_SendHkCmd(const CFE_ES_SendHkCmd_t *data)

Check notice

Code scanning / CodeQL

Function too long Note

CFE_ES_SendHkCmd has too many lines (106, while 60 are allowed).
@@ -42,7 +42,7 @@
* See description in header file for argument/return detail
*
*-----------------------------------------------------------------*/
int32 CFE_TBL_HousekeepingCmd(const CFE_MSG_CommandHeader_t *data)
int32 CFE_TBL_SendHkCmd(const CFE_TBL_SendHkCmd_t *data)

Check notice

Code scanning / CodeQL

Function too long Note

CFE_TBL_SendHkCmd has too many lines (90, while 60 are allowed).
@@ -1319,7 +1319,7 @@
/*
** Test the function that processes housekeeping request message
*/
void Test_CFE_TBL_HousekeepingCmd(void)
void Test_CFE_TBL_SendHkCmd(void)

Check notice

Code scanning / CodeQL

Function too long Note

Test_CFE_TBL_SendHkCmd has too many lines (78, while 60 are allowed).
@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Mar 21, 2024
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Mar 21, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Mar 21, 2024
*Combines:*

cFE equuleus-rc1+dev114
sample_app equuleus-rc1+dev46

**Includes:**

*cFE*
- nasa/cFE#2387
- nasa/cFE#2531

*sample_app*
- nasa/sample_app#218
- nasa/sample_app#216

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
@dzbaker dzbaker merged commit 239b224 into nasa:main Mar 21, 2024
22 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Mar 21, 2024
*Combines:*

cFE equuleus-rc1+dev114
sample_app equuleus-rc1+dev46

**Includes:**

*cFE*
- nasa/cFE#2387
- nasa/cFE#2531

*sample_app*
- nasa/sample_app#218
- nasa/sample_app#216

Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
@jphickey jphickey deleted the fix-2530-sendhk-naming branch April 5, 2024 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct SendHk command naming mismatches
2 participants