Hotfix #2526, add missing memset() for stack variables #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct two cases where struct variables on the stack were not being properly cleared before use.
jphickey
added
CCB:Ready
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Mar 12, 2024
*Combines:* cFE equuleus-rc1+dev107 to_lab equuleus-rc1+dev48 ci_lab equuleus-rc1+dev61 sample_app equuleus-rc1+dev40 **Includes:** *cFE* - nasa/cFE#2517 - nasa/cFE#2527 *to_lab* - nasa/to_lab#194 *ci_lab* - nasa/ci_lab#177 *sample_app* - nasa/sample_app#229 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Mar 12, 2024
*Combines:* cFE equuleus-rc1+dev107 to_lab equuleus-rc1+dev48 ci_lab equuleus-rc1+dev61 sample_app equuleus-rc1+dev40 **Includes:** *cFE* - nasa/cFE#2517 - nasa/cFE#2527 *to_lab* - nasa/to_lab#194 *ci_lab* - nasa/ci_lab#177 *sample_app* - nasa/sample_app#229 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker
added
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Correct two cases where struct variables on the stack were not being properly cleared before use.
Hot Fix for PR #2526 - addresses issues when running workflows
Testing performed
Run workflows
Expected behavior changes
Workflows succeed, no seg faults
System(s) tested on
Github Hosted Runner
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.