Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2493, Relative prefix exclusion for cfe implementation file search #2494

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jan 8, 2024

Checklist (Please check before submitting)

Describe the contribution

Testing performed
Standard build w/ setup described in nasa/cFS#709, where bundle directory matches *_defs name

Expected behavior changes
Finds prefixed files as expected

System(s) tested on

  • Hardware: docker
  • OS: Ubuntu 22.04
  • Versions: Main bundle + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jan 8, 2024
@skliper
Copy link
Contributor Author

skliper commented Jan 8, 2024

Ping @embeddedpenguin

@embeddedpenguin
Copy link

Confirmed on my end that this pr solves #709. Thanks for the fix!

Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me...

@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jan 18, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Jan 18, 2024
*Combines:*

ci_lab equuleus-rc1+dev51
cFE equuleus-rc1+dev79
osal equuleus-rc1+dev37

**Includes:**

*ci_lab*
- nasa/ci_lab#162
- nasa/ci_lab#171

*cFE*
- nasa/cFE#2494

*osal*
- nasa/osal#1436

Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored by: Andrew Hatstat <ahatstat@users.noreply.github.com>
Co-authored by: Dylan Baker <dzbaker@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Jan 18, 2024
2 tasks
dzbaker added a commit to nasa/cFS that referenced this pull request Jan 18, 2024
*Combines:*

ci_lab equuleus-rc1+dev51
cFE equuleus-rc1+dev79
osal equuleus-rc1+dev37

**Includes:**

*ci_lab*
- nasa/ci_lab#162
- nasa/ci_lab#171

*cFE*
- nasa/cFE#2494

*osal*
- nasa/osal#1436

Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored by: Andrew Hatstat <ahatstat@users.noreply.github.com>
Co-authored by: Dylan Baker <dzbaker@users.noreply.github.com>
@dzbaker dzbaker merged commit 99facb4 into nasa:main Jan 18, 2024
22 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Jan 18, 2024
*Combines:*

ci_lab equuleus-rc1+dev51
cFE equuleus-rc1+dev79
osal equuleus-rc1+dev37

**Includes:**

*ci_lab*
- nasa/ci_lab#162
- nasa/ci_lab#171

*cFE*
- nasa/cFE#2494

*osal*
- nasa/osal#1436

Co-authored by: Jacob Hageman <skliper@users.noreply.github.com>
Co-authored by: Andrew Hatstat <ahatstat@users.noreply.github.com>
Co-authored by: Dylan Baker <dzbaker@users.noreply.github.com>
@skliper skliper deleted the fix2493-cfe_locate_relative branch April 1, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cfe_locate_implementation_file doesn't test prefixes that match within entire path
4 participants