Fix #2430, reinstate example header files. #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These files may still be relevant to some users, and keeping them in sample_defs helps convey the fact that they are still supported for backward compatibility.
dzbaker
added
the
CCB:Approved
2 tasks
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 24, 2023
*Combines:* cFE v7.0.0-rc4+dev370 **Includes:** *cFE* - nasa/cFE#2431 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
Aug 24, 2023
*Combines:* cFE v7.0.0-rc4+dev370 **Includes:** *cFE* - nasa/cFE#2431 Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
These files may still be relevant to some users, and keeping them in sample_defs helps convey the fact that they are still supported for backward compatibility.
Note - these files are named "example" so a user must explicitly opt-in to use them, by renaming. Workflows should not use these files, they should run against the smaller/focused default values included with each component. This should preserve compatibility with the existing workflow scripts.
Fixes #2430
Testing performed
Cross check content against header files in each subcomponent
Build and sanity check CFE
Expected behavior changes
None, these files will not be used in normal builds, they are just for reference.
System(s) tested on
Debian
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.