Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2243, CFE_TBL_FILEDEF does not need static #2244

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

jphickey
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Remove the "static" qualification from the TBL file def objects, it is not needed, and works fine without any special sauce here.

Testing performed
Build and run all tests
Run CFE with apps and confirm tables load normally

Expected behavior changes
None

System(s) tested on
Debian

Additional context
Tables do not need to be declared static because they are just used with a table tool like elf2cfetbl - they are never linked with other table definition files by the C linker, so the static designation is not needed. On the other hand, it may cause issues with alternative table creation methods because it hides the symbol from e.g. dlsym(). Furthermore, it necessitates use of a compiler-specific extension flag to avoid a warning, which is against coding standards.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Remove the "static" qualification from the TBL file def objects, it is
not needed, and works fine without any special sauce here.

This also adds extended documentation to all of the FILEDEF object
members to explain naming conventions and recommended practice.
@dzbaker dzbaker added the CCB:Approved Indicates code review and approval by community CCB label Feb 16, 2023
@dzbaker dzbaker merged commit 57f02c6 into nasa:main Feb 16, 2023
@jphickey jphickey deleted the fix-2243-filedef-notstatic branch February 17, 2023 15:47
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB enhancement Equuleus-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants