Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cFE Integration candidate: 2021-08-31 #1885

Merged
merged 46 commits into from
Sep 1, 2021
Merged

cFE Integration candidate: 2021-08-31 #1885

merged 46 commits into from
Sep 1, 2021

Conversation

astrogeco
Copy link
Contributor

@astrogeco astrogeco commented Aug 25, 2021

Describe the contribution

PR #1870

PR #1869

PR #1872

PR #1871

PR #1860

PR #1862

EVS Coverage

PR #1876

SB test improvements

PR #1865

PR#1881

PR #1877,

PR #1884

PR #1889

PR #1891,

PR #1894

PR #1904

Improve TBL code coverage

PR #1864

PR #1913

Testing performed
Ubuntu CI
cFE Checks https://github.com/nasa/cFE/pull/1885/checks
cFS Bundle Checks https://github.com/nasa/cFS/pull/348/checks

Expected behavior changes
See PRs

System(s) tested on
Ubuntu CI
RTEMS CI (cFS bundle)

Additional context
Part of nasa/cFS#348

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
@jphickey
@skliper
@pepepr08
@ArielSAdamsNASA
@jbohren-hbr
@zanzaben

jphickey and others added 19 commits August 23, 2021 14:08
Adds SB functional test cases to cover all missing items that
were identified as part of the scrub in issue #1724.

Where a specific condition is not testable because it requires
a failure of another subsystem, it is marked as `covtest` to
indicate it is only verifiable in coverage test environment.
Adds ES functional test cases to cover all missing items that
were identified as part of the scrub in issue #1724.

Where a specific condition is not testable because it requires
a failure of another subsystem, it is marked as `covtest` to
indicate it is only verifiable in coverage test environment.
Adds FS functional test cases to cover all missing items that
were identified as part of the scrub in issue #1724.

Where a specific condition is not testable because it requires
a failure of another subsystem, it is marked as `covtest` to
indicate it is only verifiable in coverage test environment.
Adds TBL functional test cases to cover all missing items that
were identified as part of the scrub in issue #1724.

Where a specific condition is not testable because it requires
a failure of another subsystem, it is marked as `covtest` to
indicate it is only verifiable in coverage test environment.
Use the CFE_SB_PEND_FOREVER flag on a few of the calls to CFE_SB_ReceiveBuffer
to confirm that this works as expected.  Previously only CFE_SB_POLL and
a nonzero timeout were used.

Note this can only be used when it is known/expected that the message
queue is not empty.  If there is any possiblility that the queue is empty,
then this cannot be used or else the test may block.  This also means that
if the test fails, it may fail by blocking and never finishing the test
rather than an actual FAIL testcase.
Add test cases to confirm that when multiple pipes are subscribed
to the same message ID, that:

1. Broadcasting (transmit side) is successful even if some of the pipes
   are not deliverable.
2. MsgLimit (from subscription) and PipeDepth (from pipe create) are honored.
3. If some pipes are undeliverable for any reason, delivery to open pipes is
   not affected.
Extends the broadcast test case to cover unsubscription of a single pipe ID.
Confirms that other pipes/subscriptions are not affected, and that the limits
initially enforced on those original subscriptions still apply.
Add test cases to the zero copy sequence to confirm proper override
and/or increment of the sequence count.
Invoke CFE_ES_ExitChildTask from the main test task, to confirm
that the task does not actually exit.  There is no status code
but the fact that the test keeps running is evidence that the
task did not exit (which means the test passed).
@astrogeco astrogeco marked this pull request as ready for review September 1, 2021 04:33
@astrogeco
Copy link
Contributor Author

Failing test is due to osal dependency see nasa/cFS#348 for working bundle, test should work once osal and cfe are merged into main

@astrogeco astrogeco merged commit e5d4ed9 into main Sep 1, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 1, 2021
**Combines**

nasa/cFE#1885,              v6.8.0-rc1+dev980
nasa/osal#1138,             v5.1.0-rc1+dev598
nasa/cFS-GroundSystem#195,  v2.2.0-rc1+dev63

**Includes**

*cFE*

nasa/cFE#1870, Add SB API test cases
nasa/cFE#1869, Add ES API test cases
nasa/cFE#1872, Add TBL API test cases
nasa/cFE#1871, Add FS API test cases
nasa/cFE#1860, Add Time Clock Test
nasa/cFE#1862, EVS coverage test
nasa/cFE#1876, SB test improvements
nasa/cFE#1865, CFE_TBL_Modified: Test CRC, updated flag
nasa/cFE#1881, Improve EVS code coverage
nasa/cFE#1877, add call to CFE_ES_ExitChildTask
nasa/cFE#1902, Incorrect OSAL Format in Users Guide Reference
nasa/cFE#1884, Improve FS coverage
nasa/cFE, Improve MSG branch coverage
nasa/cFE#1891, Improve resource ID branch coverage
nasa/cFE#1894, Improve SBR branch coverage
nasa/cFE#1896, Fix #1895, Improve TIME branch coverage
nasa/cFE#1904, Improve TBL code coverage
nasa/cFE#1864, Support custom PSP directory
nasa/cFE#1913, Update time tests to use bitmask check macros
nasa/cFE#1923, remove extra word in comment

*osal*

nasa/osal#1136, add bitmask assert macros

*cFS-GroundSystem*

nasa/cFS-GroundSystem#190, Fix #189, Virtualenv and Pipenv .gitignore support
nasa/cFS-GroundSystem#194, Fix doc, comment, and message typos

Co-authored-by: Jacob Hageman           <skliper@users.noreply.github.com>
Co-authored-by: Joseph Hickey           <jphickey@users.noreply.github.com>
Co-authored-by: Alex Campbell           <zanzaben@users.noreply.github.com>
Co-authored-by: Ariel Adams             <ArielSAdamsNASA@users.noreply.github.com>
Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com>
Co-authored-by: Avi                     <thnkslprpt@users.noreply.github.com>
Co-authored-by: Paul                    <pavll@users.noreply.github.com>
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment