Fix #1308, Removed redundant check/set of CFE_CPU_ID_VALUE

[skliper]

Describe the contribution
Fix #1308 - removed redundant set of CFE_CPU_ID_VALUE if not set.

And checked as well as assigned to CFE_CPU_ID_VALUE here:

cFE/cmake/target/CMakeLists.txt

Lines 20 to 22 in 176e3df

	if (NOT DEFINED ${TGTNAME}_PROCESSORID)
	message(FATAL_ERROR "${TGTNAME}_PROCESSORID must be defined to link a final exe")
	endif (NOT DEFINED ${TGTNAME}_PROCESSORID)

cFE/cmake/target/CMakeLists.txt

Lines 127 to 133 in 176e3df

	target_compile_definitions(core-${TGTNAME} PRIVATE
	CFE_DEFAULT_MODULE_EXTENSION="${CMAKE_SHARED_MODULE_SUFFIX}"
	CFE_DEFAULT_CORE_FILENAME="$<TARGET_FILE_NAME:core-${TGTNAME}>"
	CFE_CPU_NAME_VALUE="${TGTNAME}"
	CFE_SPACECRAFT_ID_VALUE=${SPACECRAFT_ID}
	CFE_CPU_ID_VALUE=${${TGTNAME}_PROCESSORID}
	)

and used here:

cFE/cmake/target/src/target_config.c

Line 172 in 176e3df

.Default_CpuId = CFE_CPU_ID_VALUE,

Testing performed
Removed assignment of cpu1_PROCESSORID and confirmed error was generated by target/CMakeLists.txt:
cpu1_PROCESSORID must be defined to link a final exe

Expected behavior changes
None as long as required elements are defined.

System(s) tested on

• Hardware: Intel I5/Docker
• OS: Ubuntu 18.04
• Versions: Bundle Main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

[astrogeco]

CCB:2021-06-02 APPROVED