Fix #982, separate pipeinfo file data structure #1102
Conversation
…ds' into jph-wip-baseline-20210115
Define a data structure in cfe_sb_msg.h that will be used with the "write pipe info" command (CFE_SB_SEND_PIPE_INFO_CC). This allows the internal CFE_SB_PipeD_t descriptor object to evolve as needed without affecting the binary format of the file that is generated form this command, and items such as memory pointers may be excluded from the file.
|
CCB:2021-01-21 APPROVED |
|
@astrogeco - This has been approved... does it need a tag update and merge? |
I think this was probably a last-minute CCB addition since the "ready" label is missing; I missed it. Thanks for catching it! |
I did notice it's still in draft mode @jphickey did you mean to change anything here? |
|
I think it's only as draft since it depends on merges that are still in IC... if you update target to IC they should go away. |
I just clicked the button :) |
|
I still needed to rebase this.... it looks like I'm too late though |
sorry!! Feel free to push to the cFE IC branch if there's anything we need to fix... |
|
Problem is it picked up an extra commit (0f4ed8f) which was a temporary merge I had locally done of the prerequisites. My normal process is to rebase to "main" once those prerequisites are merged. Should I force-push to |
Fix #982, separate pipeinfo file data structure
|
Rebased and fixed merge in integration-candidate - all good now. |
Describe the contribution
Provide a separate/dedicated structure for use in the "Pipe Info" file as written by the
CFE_SB_SEND_PIPE_INFO_CCcommand, instead of using theCFE_SB_PipeD_twhich is supposed to be internal/private.Data is extracted from the internal
CFE_SB_PipeD_twhile shared data locked and staged into this new format, then the shared data is unlocked while the other information is gathered and finally written to the file.Fixes #982
Fixes #995
Testing performed
Build CFE and sanity check, run all unit tests
Run the
CFE_SB_SEND_PIPE_INFO_CCand confirm that the file is generated.Expected behavior changes
This changes the binary format of the generated pipe info file. However after this is merged the format of the fine should be more stable going forward, as internal changes to the
CFE_SB_PipeD_twill no longer affect it.System(s) tested on
Ubuntu 20.04
Additional context
This still needs a rebase as it depends on #1092.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.