Fix #1090, UT event check bounds #1091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Divide the "position" (in bytes) by the size of the event IDs to get the number of events. Also correct bad event checks in TBL UT.
jphickey
added
the
CCB:Ready
skliper
approved these changes
Jan 12, 2021
Contributor
|
CCB:2021-01-13 APPROVED Uncovered some test and event issues. |
astrogeco
added
CCB:2021-01-13
and removed
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes
UT_CheckEventHistoryFromFunc()helper routine to read the correct number of IDs. Divide the "position" (in bytes) by the size of the event IDs to get the number of events.Also correct bad event checks in TBL UT.
Fixes #1090
Testing performed
Build and run all unit tests
Expected behavior changes
UT_CheckEventHistoryFromFunc() works properly now.
System(s) tested on
Ubuntu 20.04
Additional context
Only Unit test is affected, no FSW
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.