ES uncovered branch in CFE_ES_TaskEntryPoint, conditions not independent (defensive code)

[skliper]

Is your feature request related to a problem? Please describe.
Uncovered branch since RealEntryFunc always != NULL when CFE_ES_GetTaskFunction returns CFE_SUCCESS:

     561                 :          4 : void CFE_ES_TaskEntryPoint(void)
     562                 :            : {
     563                 :            :     CFE_ES_TaskEntryFuncPtr_t RealEntryFunc;
     564                 :            : 
     565 [ +  + ][ +  - ]:          4 :     if (CFE_ES_GetTaskFunction(&RealEntryFunc) == CFE_SUCCESS && RealEntryFunc != NULL)

here:

cFE/modules/es/fsw/src/cfe_es_apps.c

Lines 561 to 565 in e5d4ed9

	void CFE_ES_TaskEntryPoint(void)
	{
	CFE_ES_TaskEntryFuncPtr_t RealEntryFunc;
	if (CFE_ES_GetTaskFunction(&RealEntryFunc) == CFE_SUCCESS && RealEntryFunc != NULL)

Describe the solution you'd like
If CFE_ES_GetTaskFunction was stubbed this could be exercised (or alternate implementation). These are both internal functions so really doesn't require a NULL check.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

[avan989]

code coverage is not possible.

Targeted condition:

1. CFE_ES_GetTaskFunction == CFE_SUCCESS
2. RealEntryFunc == NULL

The following path is taken:

1. CFE_ES_TaskEntryPoint (cfe_es_app.c) -> CFE_ES_GetTaskFunction (Not A Stub. cfe_es_app.c)

CFE_ES_GetTaskFunction sets RealEntryFunc and also has a "ReturnCode". It is not possible to have a "CFE_SUCCESS" return code and a "NULL" RealEntryFunc.

cFE/modules/es/fsw/src/cfe_es_apps.c

Lines 516 to 520 in 112bc51

	EntryFunc = TaskRecPtr->EntryFunc;
	if (CFE_RESOURCEID_TEST_DEFINED(TaskRecPtr->AppId) && EntryFunc != 0)
	{
	ReturnCode = CFE_SUCCESS;
	}