Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag to CFE_SB_DestinationD_t structure and use it instead of void * for Prev and Next #1455

Closed
skliper opened this issue Apr 29, 2021 · 0 comments · Fixed by #1565 or #1584
Closed

Add tag to CFE_SB_DestinationD_t structure and use it instead of void * for Prev and Next #1455

skliper opened this issue Apr 29, 2021 · 0 comments · Fixed by #1565 or #1584
Labels
cFE-SB CFS-42 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Apr 29, 2021

Is your feature request related to a problem? Please describe.
Void pointers used in CFE_SB_DestinationD_t:

cFE/modules/core_private/fsw/inc/cfe_sb_destination_typedef.h

Lines 41 to 52 in c8b5e00

typedef struct
{
CFE_SB_PipeId_t PipeId;
uint8 Active;
uint16 MsgId2PipeLim;
uint16 BuffCount;
uint16 DestCnt;
uint8 Scope;
uint8 Spare[3];
void * Prev;
void * Next;
} CFE_SB_DestinationD_t;

Describe the solution you'd like
Defining a tag and use in pointer definitions

Describe alternatives you've considered
None

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone Apr 29, 2021
skliper added a commit to skliper/cFE that referenced this issue May 21, 2021
@skliper
Fix nasa#1455, Add CFE_SB_DestinationD tag and use for pointers
1dd25f2
@skliper skliper mentioned this issue May 21, 2021
Merged
skliper added a commit to skliper/cFE that referenced this issue May 21, 2021
@skliper
Fix nasa#1455, Add CFE_SB_DestinationD tag and use for pointers
8c84e57
astrogeco added a commit that referenced this issue May 27, 2021
@astrogeco
Merge pull request #1565 from skliper/fix1455-destination_tag
9a01dcc 
Fix #1455, Add CFE_SB_DestinationD tag and use for pointers
@astrogeco astrogeco mentioned this issue Jun 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cFE-SB CFS-42 enhancement
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco