Fix #45, manage tables every cycle instead of via command #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
|
|
||
| void SC_RegisterManageCmds(void) | ||
| void SC_ManageTables(void) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
|
|
||
| void SC_RegisterManageCmds(void) | ||
| void SC_ManageTables(void) |
Check notice
Code scanning / CodeQL
Function too long Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
SC_ManageTables) to manage all tables with each app cycle - instead of by command for individually specified tables.Note:
Might need to add back the previous SC_MANAGE_TABLE_CC and associated command functions (maybe behind deprecation guards) for backward-compatibility but have left out of this pull request for now to make review of the new version simpler.
Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).
New tests added in
unit-test/sc_app_tests.ccovering the main logic paths (not exactly 100% MC/DC coverage but close).Expected behavior changes
A lot of complexity can be removed from the app with this update.
System(s) tested on
Debian 12 using the current main branch of cFS bundle.
Contributor Info
Avi Weiss @thnkslprpt