Skip to content

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Nov 19, 2019

Describe the contribution
Fixes #112

Testing performed
Steps taken to test the contribution:

  1. Checked out bundle with ic-20191115 branches
  2. make ENABLE_UNIT_TESTS=TRUE SIMULATION=native prep
  3. make
  4. make install
  5. make test
    Built without warnings, all tests passed except osal_timer_UT (nominal result on linux)
    executed cfe, successful startup with no warnings

Confirmed passed CI (with cppcheck enforced!)

Expected behavior changes
No functional changes, doxygen warning cleanup.

System(s) tested on:

  • cFS dev server
  • OS: Ubuntu 16.04
  • Versions: bundle ic-20191115 branch

Additional context
None

Contributor Info
Jacob Hageman - NASA/GSFC

avan989 and others added 2 commits November 5, 2019 09:49
Fixes #112 
Code reviewed and approved at 20191106 CCB
@skliper skliper requested a review from jphickey November 19, 2019 15:49
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanity-checked as part of CFS bundle on Ubuntu 18.04 64-bit and Raspberry Pi (Raspbian 32-bit). Confirmed successful build and execution of CFE.

Also confirmed successful build for MCP750/VxWorks 6.9 using GSFC build machine.

@skliper skliper merged commit faca0cc into master Nov 30, 2019
@skliper skliper deleted the ic-20191115 branch November 30, 2019 19:38
@skliper skliper added this to the 1.5.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

doxygen warning

3 participants