Add user group management #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpsinger
requested changes
May 21, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2268 +/- ##
========================================
- Coverage 5.27% 5.22% -0.06%
========================================
Files 157 163 +6
Lines 3906 4042 +136
Branches 419 439 +20
========================================
+ Hits 206 211 +5
- Misses 3699 3830 +131
Partials 1 1 ☔ View full report in Codecov by Sentry. |
dakota002
force-pushed
the
AdminUserGroups
branch
from
761b976
to
e1c3b02
Compare
Adds some checks that the user is an admin Adds more checks for user group Update app/routes/admin.users._index.tsx Co-authored-by: Leo Singer <leo.p.singer@nasa.gov> Co-authored-by: Leo Singer <leo.p.singer@nasa.gov> Update app/lib/cognito.server.ts Co-authored-by: Leo Singer <leo.p.singer@nasa.gov> Update app/routes/admin.users.$userId.tsx Co-authored-by: Leo Singer <leo.p.singer@nasa.gov> Refactors and simplifications
dakota002
force-pushed
the
AdminUserGroups
branch
from
e1c3b02
to
2399300
Compare
lpsinger
requested changes
Jul 29, 2024
|
Actually still making changes |
…x string comparisons to check against same cases
|
Okay now it is ready |
lpsinger
requested changes
Aug 1, 2024
lpsinger
requested changes
Aug 1, 2024
lpsinger
requested changes
Aug 1, 2024
lpsinger
requested changes
Aug 5, 2024
lpsinger
approved these changes
Aug 6, 2024
Vidushi-GitHub
pushed a commit
to Vidushi-GitHub/gcn.nasa.gov
that referenced
this pull request
Oct 13, 2024
Vidushi-GitHub
pushed a commit
to Vidushi-GitHub/gcn.nasa.gov
that referenced
this pull request
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds admin pages for managing user's group associations
Testing
Ran locally, tested adding/removing groups that user's belong to