Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(classes, core): add ability to map Date[] types #399

Merged
merged 2 commits into from
Jan 11, 2022
Merged

fix(classes, core): add ability to map Date[] types #399

merged 2 commits into from
Jan 11, 2022

Conversation

roblopz
Copy link
Contributor

@roblopz roblopz commented Jan 9, 2022

  • Adding support for Date[] type mappings on classes/pojo.
  • Adding tests for the above cases.

fix(classes, core): add ability to map Date[] types
d2d6323 
instantiate.util.ts@classes and map@core weren't mapping Date[] types correctly. Add checks for this
case.

nartc#397
@roblopz roblopz mentioned this pull request Jan 9, 2022
Closed
9 tasks
nartc
nartc previously approved these changes Jan 10, 2022
View reviewed changes
@nartc nartc dismissed their stale review January 10, 2022 01:57

Missed pojos

nartc
nartc reviewed Jan 10, 2022
View reviewed changes
Copy link
Owner

@nartc nartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just one small commetn

packages/classes/src/lib/utils/instantiate.util.ts Show resolved Hide resolved
fix(pojos): adding pojos support for Date[] types
afe534a 
Pojos instantiate util wasn't correctly handling Date[] types, adding support for them.

nartc#397
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nartc
Copy link
Owner

nartc commented Jan 11, 2022

thank you for the pr

@nartc nartc merged commit cb27b1a into nartc:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nartc nartc nartc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roblopz @nartc