feat(core): adjust typings to support more custom type converter

nartc · Dec 20, 2021 · 6ef280f · 6ef280f
1 parent 961160c
commit 6ef280f
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 9 deletions.
diff --git a/packages/core/src/lib/create-mapper/apply-type-converters.util.ts b/packages/core/src/lib/create-mapper/apply-type-converters.util.ts
@@ -20,9 +20,9 @@ import {
  */
 export function applyTypeConverters(
   mapping: Mapping,
-  typeConverters: WeakMap<
+  typeConverters: Map<
     PrimitiveConstructorExtended,
-    WeakMap<PrimitiveConstructorExtended, ValueSelector | Converter>
+    Map<PrimitiveConstructorExtended, ValueSelector | Converter>
   >
 ): void {
   const [, , initializedProps] = mapping;

diff --git a/packages/core/src/lib/create-mapper/create-mapper.ts b/packages/core/src/lib/create-mapper/create-mapper.ts
@@ -33,9 +33,9 @@ export function createMapper<TKey = unknown>({
   const plugin = pluginInitializer(errorHandler);
 
   // type converters
-  const typeConverters = new WeakMap<
+  const typeConverters = new Map<
     PrimitiveConstructorExtended,
-    WeakMap<PrimitiveConstructorExtended, ValueSelector | Converter>
+    Map<PrimitiveConstructorExtended, ValueSelector | Converter>
   >();
 
   return {
@@ -50,7 +50,7 @@ export function createMapper<TKey = unknown>({
 
       typeConverters.set(
         source,
-        new WeakMap<PrimitiveConstructorExtended, ValueSelector | Converter>([
+        new Map<PrimitiveConstructorExtended, ValueSelector | Converter>([
           [destination, converter],
         ])
       );

diff --git a/packages/core/src/lib/types/core.ts b/packages/core/src/lib/types/core.ts
@@ -2,6 +2,7 @@ import { TransformationType } from './enums';
 import type { CreateMapOptions, MapArrayOptions, MapOptions } from './options';
 import type {
   Dictionary,
+  PrimitiveConstructor,
   PrimitiveConstructorExtended,
   PrimitiveExtended,
   Selector,
@@ -161,7 +162,9 @@ export type MapInitializeReturn<
 
 export type PrimitiveConstructorReturnType<
   TType extends PrimitiveConstructorExtended
-> = TType extends DateConstructor ? InstanceType<TType> : ReturnType<TType>;
+> = TType extends DateConstructor | Exclude<TType, PrimitiveConstructor>
+  ? InstanceType<TType>
+  : ReturnType<Extract<TType, PrimitiveConstructor>>;
 
 export interface Mapper {
   name: string;

diff --git a/packages/core/src/lib/types/utils.ts b/packages/core/src/lib/types/utils.ts
@@ -21,7 +21,8 @@ export type PrimitiveConstructor =
 
 export type PrimitiveConstructorExtended =
   | PrimitiveConstructor
-  | DateConstructor;
+  | DateConstructor
+  | (new (...args: any[]) => any);
 
 export interface Selector<
   TObject extends Dictionary<TObject> = any,

diff --git a/packages/core/src/lib/utils/is-date-constructor.util.ts b/packages/core/src/lib/utils/is-date-constructor.util.ts
@@ -4,5 +4,5 @@
  * @param {Function} value
  */
 export function isDateConstructor(value: unknown): boolean {
-  return value === Date;
+  return Object.getPrototypeOf(value) === Date || value === Date;
 }
diff --git a/packages/core/src/lib/utils/is-primitive-constructor.util.ts b/packages/core/src/lib/utils/is-primitive-constructor.util.ts
@@ -4,7 +4,14 @@
  * @param {Function} value
  */
 export function isPrimitiveConstructor(value: unknown): boolean {
+  const proto = Object.getPrototypeOf(value);
   return (
-    value === String || value === Number || value === Boolean || value === Array
+    proto === String ||
+    proto === Number ||
+    proto === Boolean ||
+    value === String ||
+    value === Number ||
+    value === Boolean ||
+    value === Array
   );
 }