Fixing bug

narendravaghela · Jan 5, 2019 · 9f43a45 · 9f43a45
1 parent d43d1c5
commit 9f43a45
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/Mailer/MailgunEmail.php b/src/Mailer/MailgunEmail.php
@@ -38,7 +38,7 @@ public function setTags($tags)
             throw new MailgunApiException('You can only set a max of 3 tags.');
         }
 
-        $this->addHeaders(['X-Mailgun-Tag' => implode(',', $tags)]);
+        $this->addHeaders(['X-Mailgun-Tag' => json_encode($tags)]);
 
         return $this;
     }

diff --git a/tests/TestCase/Mailer/MailgunEmailTest.php b/tests/TestCase/Mailer/MailgunEmailTest.php
@@ -36,10 +36,10 @@ public function tearDown()
 
     public function testTagsArray()
     {
-        $this->Email->setTags(['tag1', 'tag2', 'tag3']);
+        $tags = ['tag1', 'tag2', 'tag3'];
+        $this->Email->setTags($tags);
         $headers = $this->Email->getHeaders(['X-Mailgun-Tag']);
-        $expected = 'tag1,tag2,tag3';
-        $this->assertEquals($expected, $headers['X-Mailgun-Tag']);
+        $this->assertEquals(json_encode($tags), $headers['X-Mailgun-Tag']);
     }
 
     public function testTagsArrayMoreThanThree()
@@ -54,7 +54,7 @@ public function testTagString()
     {
         $this->Email->setTags('tag1,tag2,tag3');
         $headers = $this->Email->getHeaders(['X-Mailgun-Tag']);
-        $expected = 'tag1,tag2,tag3';
+        $expected = json_encode(['tag1', 'tag2', 'tag3']);
 
         $this->assertEquals($expected, $headers['X-Mailgun-Tag']);
     }