Skip to content

Conversation

@napulen
Copy link
Owner

@napulen napulen commented Jun 20, 2022

Fixes #79

The chosen strategy was to look for music21.stream.Parts with a PercussionClef object within and remove them.

This is done only in the score_parser because it shouldn't affect annotation files or synthetic examples. Those will never have a percussion track.

@codecov-commenter
Copy link

Codecov Report

Merging #80 (ce830b0) into main (0c91b48) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #80      +/-   ##
==========================================
+ Coverage   74.95%   74.98%   +0.03%     
==========================================
  Files          47       47              
  Lines        2380     2383       +3     
==========================================
+ Hits         1784     1787       +3     
  Misses        596      596              
Impacted Files Coverage Δ
AugmentedNet/score_parser.py 96.96% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c91b48...ce830b0. Read the comment docs.

@napulen napulen merged commit c293a90 into main Jun 20, 2022
@napulen napulen deleted the remove_drum_parts branch June 22, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore/Remove percussion clefs when preprocessing MusicXML files

3 participants