Merged
Conversation
brisvag
approved these changes
Jul 22, 2024
melonora
approved these changes
Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that we are building docs but not deploying docs when we merge
napari/napari PRs, and also on manually-triggered workflows. Only merges to
main on the napari/docs repo get deployed.
This PR also adds workflow_dispatch to the conditions in which built docs are
deployed. (This is also the mechanism by which merges in napari/napari trigger
docs building in the this repo.)
I have also added actionlint from napari/napari#7049 so that I can play aroundEdit: Actionlint was failing on unrelated parts of the action, so I have decided to split it into a separate PR.with the long conditional and line continuations without screwing everything
up. 😂