Add announcement banner html to enable config #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Czaki
approved these changes
Jan 31, 2024
This was referenced Jan 31, 2024
Czaki
added a commit
that referenced
this pull request
Jan 31, 2024
# References and relevant issues Together with #341, this PR supersedes #332. # Description The announcement banner text html was added in #341. This PR now points our config to it, allowing the banner to be displayed. Note: #332 also has a CSS fix. However, that fix is included in the latest release of the napari-sphinx-theme, so I think it's best to leave it out of this PR. (I would be happy to make a separate PR for it if we don't want to wait until the dependencies are updated.) Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
First part of #332: make sure the banner html is publicly accessible on
napari.org.
Description
Discussion on Zulip.
After this is merged, the banner text will live in
https://napari.org/dev/_static/announcement.html
forever. Since that file can be updated with a merge to main here, it is easy
to add or remove announcements, pending the pydata-sphinx-theme removing the
banner when the text is empty (see @melissawm's changes soon to be
suggested).