-
Notifications
You must be signed in to change notification settings - Fork 129
2D Periodic Navier Stokes Model #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ncodes16
wants to merge
35
commits into
nansencenter:master
Choose a base branch
from
ncodes16:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions for later
…is in action. Next step: trouble shooting example_paper.py with basic_1.py (as a test) to find dimension issues. Used bocquet2019 as inspiration for structure of example paper. Also: write documentation in md
todo test more and make MUCH faster
Todo-modify the RV generation for the initial cases (X0 = modelling.RV) so that it follows the QG generation/works with the other models.
…se (0 error obviously); some noise causes it to blow up. Temp aid - clamping values in solver between -1 and 1 to delay blowup.
…trefethen for better stability
… labels on plots, not just grid #
Collaborator
|
Dear Nabeel Chasmawala, Thank you for the pull request. I'm sorry for the long delay for our reply. I don't have the time right now, but will try to review your PR asap, although that may still be weeks ahead. Thank you for your patience! |
Author
|
Thank you for the update. I look forward to hearing your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Professors Raanes, Chen, Grudzien, Tondeur, and Dubois,
I am Nabeel Chasmawala, a high schooler from Connecticut, USA. I conducted research in data assimilation with Dr. Chang Liu (@cliu124) at the University of Connecticut, Storrs this past summer using the DAPPER framework. This research culminated in the creation of a Navier-Stokes equation dynamic model for use with DAPPER, and that is what this pull request contains. I also include a report (linked here) explaining the implementation and theory behind the model for further explanation, as well as some sample DA results for proof-of-concept.
Please let me know if you have any questions about this and I hope you find this a good fit for DAPPER.
Best,
Nabeel