-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broker aio already in list. #977
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use this aio to forward msgs. This aio may already in a list. then nng_aio_begin will failed. Signed-off-by: wanghaemq <wangwei@emqx.io>
Should we put ctx instead of aio to send_queue.? Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
wanghaEMQ
changed the title
[WIP] Fix broker aio already in list.
Fix broker aio already in list.
Jun 5, 2024
wanghaEMQ
requested review from
StargazerWayne,
JaylinYu,
xinyi-xs,
a team and
RanMaoyi
June 5, 2024 07:30
Signed-off-by: wanghaemq <wangwei@emqx.io>
xinyi-xs
approved these changes
Jun 5, 2024
JaylinYu
requested changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aa We discussed, still has issue remain
Signed-off-by: wanghaemq <wangwei@emqx.io>
I think this commit ff9315c has fixed the issue. Help test it when you are free. |
xinyi-xs
approved these changes
Jun 7, 2024
JaylinYu
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not fixed yet
Plz continue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.