Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broker aio already in list. #977

Merged
merged 9 commits into from
Jun 7, 2024
Merged

Fix broker aio already in list. #977

merged 9 commits into from
Jun 7, 2024

Conversation

wanghaEMQ
Copy link
Member

No description provided.

use this aio to forward msgs. This aio may already in a list. then
nng_aio_begin will failed.

Signed-off-by: wanghaemq <wangwei@emqx.io>
Should we put ctx instead of aio to send_queue.?

Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ wanghaEMQ marked this pull request as draft June 3, 2024 08:12
Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
Signed-off-by: wanghaemq <wangwei@emqx.io>
@JaylinYu JaylinYu marked this pull request as ready for review June 5, 2024 07:30
@wanghaEMQ wanghaEMQ changed the title [WIP] Fix broker aio already in list. Fix broker aio already in list. Jun 5, 2024
Signed-off-by: wanghaemq <wangwei@emqx.io>
Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aa We discussed, still has issue remain

Signed-off-by: wanghaemq <wangwei@emqx.io>
@wanghaEMQ
Copy link
Member Author

I think this commit ff9315c has fixed the issue. Help test it when you are free.

@wanghaEMQ wanghaEMQ requested a review from JaylinYu June 7, 2024 03:28
Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not fixed yet
Plz continue

@JaylinYu JaylinYu merged commit 38cfd98 into main Jun 7, 2024
13 of 15 checks passed
@wanghaEMQ wanghaEMQ deleted the wangha/fix branch June 11, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants