fix h-b-o #1720 #906
Merged
fix h-b-o #1720 #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wayne <yukang.wei@emqx.io>
StargazerWayne
requested review from
RanMaoyi,
JaylinYu,
xinyi-xs and
wanghaEMQ
|
not quite sure about this, plz review this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #906 +/- ##
==========================================
+ Coverage 65.17% 65.20% +0.02%
==========================================
Files 130 130
Lines 37911 37911
==========================================
+ Hits 24709 24719 +10
+ Misses 13202 13192 -10 ☔ View full report in Codecov by Sentry. |
Signed-off-by: wayne <yukang.wei@emqx.io>
StargazerWayne
changed the title
StargazerWayne
changed the title
Signed-off-by: wayne <yukang.wei@emqx.io>
StargazerWayne
force-pushed
the
wayne/dev
branch
from
302c834
to
87f64a8
Compare
Signed-off-by: wayne <yukang.wei@emqx.io>
StargazerWayne
changed the title
wanghaEMQ
approved these changes
Mar 29, 2024
| if (cparam->pro_ver == MQTT_PROTOCOL_VERSION_v5) { | ||
| // check length | ||
| log_trace("Decoding MQTT V5 Properties"); | ||
| if (pos >= max) | ||
| if (pos + 4 >= max) |
There was a problem hiding this comment.
4 == 2 (property len) + 2 (clientid len). Am I right?
There was a problem hiding this comment.
it's the req of get_var_integer.
src/supplemental/nanolib/conf_ver2.c
Outdated
| // max len of pw is 20. | ||
| char strpw[20]; | ||
| sprintf(strpw, "%d", ele->valueint); | ||
| cvector_push_back(auth->passwords, nng_strdup(strpw)); |
There was a problem hiding this comment.
I don't think the password can be a number
There was a problem hiding this comment.
I dont think it is really needed
There was a problem hiding this comment.
just revert it, gonna update docs and tell users to add "" .
Signed-off-by: wayne <yukang.wei@emqx.io>
StargazerWayne
changed the title
JaylinYu
approved these changes
Mar 30, 2024
src/supplemental/nanolib/conf_ver2.c
Outdated
| // max len of pw is 20. | ||
| char strpw[20]; | ||
| sprintf(strpw, "%d", ele->valueint); | ||
| cvector_push_back(auth->passwords, nng_strdup(strpw)); |
There was a problem hiding this comment.
I dont think it is really needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.