fix for https://github.com/nanomq/nanomq/issues/1719 #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
Signed-off-by: wayne <yukang.wei@emqx.io>
StargazerWayne
force-pushed
the
wayne/dev
branch
from
a06dff5
to
9c4ff5b
Compare
Signed-off-by: wayne <yukang.wei@emqx.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #903 +/- ##
==========================================
- Coverage 65.27% 65.24% -0.04%
==========================================
Files 130 130
Lines 37891 37898 +7
==========================================
- Hits 24734 24727 -7
- Misses 13157 13171 +14 ☔ View full report in Codecov by Sentry. |
StargazerWayne
commented
Mar 26, 2024
StargazerWayne
requested review from
RanMaoyi,
JaylinYu,
xinyi-xs and
wanghaEMQ
wanghaEMQ
approved these changes
Mar 26, 2024
Signed-off-by: wayne <yukang.wei@emqx.io>
JaylinYu
approved these changes
Mar 27, 2024
| @@ -1861,6 +1867,10 @@ topic_filter(const char *origin, const char *input) | |||
| bool | |||
| topic_filtern(const char *origin, const char *input, size_t n) | |||
| { | |||
| // Wrong topic or invalid topic alias | |||
| if (input == NULL || origin == NULL) | |||
| return false; | |||
There was a problem hiding this comment.
doens't it conflict with topic alias?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.