Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First version of blf library. #878

Merged
merged 14 commits into from
Feb 27, 2024
Merged

First version of blf library. #878

merged 14 commits into from
Feb 27, 2024

Conversation

xinyi-xs
Copy link
Contributor

No description provided.

Signed-off-by: xinyi-xs <lihj@emqx.io>
Signed-off-by: xinyi-xs <lihj@emqx.io>
Signed-off-by: xinyi-xs <lihj@emqx.io>
Signed-off-by: xinyi-xs <lihj@emqx.io>
Signed-off-by: xinyi-xs <lihj@emqx.io>
Signed-off-by: xinyi-xs <lihj@emqx.io>
Signed-off-by: xinyi-xs <lihj@emqx.io>
Signed-off-by: xinyi-xs <lihj@emqx.io>
Signed-off-by: xinyi-xs <lihj@emqx.io>
Signed-off-by: xinyi-xs <lihj@emqx.io>
Signed-off-by: xinyi-xs <lihj@emqx.io>
Signed-off-by: xinyi-xs <lihj@emqx.io>
Signed-off-by: xinyi-xs <lihj@emqx.io>
Signed-off-by: xinyi-xs <lihj@emqx.io>
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.47%. Comparing base (26986b9) to head (79b38d3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
- Coverage   65.50%   65.47%   -0.03%     
==========================================
  Files         129      129              
  Lines       37421    37421              
==========================================
- Hits        24512    24501      -11     
- Misses      12909    12920      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JaylinYu JaylinYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice
remember to support conditional compiling in cmake

@JaylinYu JaylinYu merged commit fef1417 into main Feb 27, 2024
15 of 16 checks passed
@JaylinYu JaylinYu deleted the xinyi/blf branch February 27, 2024 14:50
@xinyi-xs
Copy link
Contributor Author

nice remember to support conditional compiling in cmake

I am committed to refining it.

Copy link
Member

@wanghaEMQ wanghaEMQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants