Better types for custom elements #148
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to add some more types to the custom element registration function, mainly around ensuring that the prop name array passed to it adheres to the actual props passed to the component.
Before commit, I ran
denoify, as well as prettier and eslint.Ideally, I'd like to eradicate
anyfrom the entire codebase, but... small steps. And maybe a fork proper, if proper typings are not something the project maintanier desires.