Skip to content

Improve min max performance and IEEE compliance #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 9, 2023
Merged

Improve min max performance and IEEE compliance #2810

merged 11 commits into from
Nov 9, 2023

Conversation

CoryCharlton
Copy link
Member

Description

  • Reduce IsNan checks to improve performance
  • Fix Min not returning NaN in all cases it should
  • Implement Min(float) and Max(float)

Motivation and Context

How Has This Been Tested?

  • On device
  • Unit tests

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

nfbot and others added 2 commits November 5, 2023 05:35
@nfbot
Code style fixes
e590b42 
Automated fixes for code style.
@CoryCharlton
Merge pull request #2 from nanoframework/nfbot/clang-format-fix/06c98…
3f4faf2 
…8f9-0ea7-473f-81bb-b374d4c63e4a

Code style fixes for nanoframework/nf-interpreter PR#2810
@CoryCharlton CoryCharlton mentioned this pull request Nov 5, 2023
Merged
14 tasks
CoryCharlton and others added 4 commits November 5, 2023 21:12
@CoryCharlton
Covering the +0.0/-0.0 cases
10d8c1e
@nfbot
Code style fixes
7494b24 
Automated fixes for code style.
@CoryCharlton
Merge pull request #3 from nanoframework/nfbot/clang-format-fix/4f96d…
d2db562 
…7ee-6293-4eb1-8e4e-e9e794eefb28

Code style fixes for nanoframework/nf-interpreter PR#2810
@CoryCharlton
Fixing min double signed zero handling
a9bab5b
@CoryCharlton
Copy link
Member Author

That's all the required changes I can see so this should be stable pending any review feedback.

josesimoes
josesimoes reviewed Nov 6, 2023
View reviewed changes
@josesimoes josesimoes merged commit ac97f68 into nanoframework:main Nov 9, 2023
@CoryCharlton CoryCharlton deleted the improve_min_max branch November 9, 2023 03:35
networkfusion added a commit to networkfusion/nf-interpreter that referenced this pull request Nov 12, 2023
@networkfusion
Squashed commit of the following:
2478ce8 
commit e0fcb04
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Sun Nov 12 16:34:26 2023 +0000

    Use alternative for ChibiOS

    Git SVN is just too slow.

commit 3c4e21c
Merge: 1147cd3 4ed6ca5
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Sun Nov 12 12:22:16 2023 +0000

    Merge branch 'main' into devcontainer-superficial

commit 4ed6ca5
Author: José Simões <jose.simoes@eclo.solutions>
Date:   Sat Nov 11 15:26:30 2023 +0000

    Enable I2C Slave to most ESP32 targets (nanoframework#2828)

commit 1147cd3
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Sat Nov 11 01:41:52 2023 +0000

    Update devcontainer-smoketest.yaml

    Add matrix TI All (commented out)

commit 4b394e1
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Sat Nov 11 01:18:58 2023 +0000

    Update Dockerfile.ESP32

commit dfe1ca8
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Sat Nov 11 00:25:43 2023 +0000

    Update devcontainer-smoketest.yaml

    Fix matrix vars

commit 02b078a
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Sat Nov 11 00:21:40 2023 +0000

    Update devcontainer-smoketest.yaml

    Improve for all containers and platforms.

commit 9b52699
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Sat Nov 11 00:16:28 2023 +0000

    Update Dockerfile.All

    Use python:3.10 container

commit 5a62640
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Sat Nov 11 00:06:51 2023 +0000

    Update devcontainer-smoketest.yaml

    Comment out TI as known broken

commit e8dc1c8
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 23:57:03 2023 +0000

    Update devcontainer-smoketest.yaml

    Include TI target as last container.

commit 6f629a4
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 23:40:30 2023 +0000

    Update Dockerfile.AzureRTOS

    Fix extra slash

commit e362416
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 23:24:16 2023 +0000

    Update devcontainer-smoketest.yaml

    Use submodules

commit c4b314a
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 23:18:35 2023 +0000

    Update devcontainer-smoketest.yaml

    Fix sed command

commit 1bb1a28
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 23:12:07 2023 +0000

    Update devcontainer-smoketest.yaml

    Run on push as well (at least for the moment

commit 472e955
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 23:09:54 2023 +0000

    Update devcontainer-smoketest.yaml

    Add GH workflows to paths

commit 6baf857
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 23:07:19 2023 +0000

    Update devcontainer-smoketest.yaml

    Fix syntax error and re-enable most src

commit 18ba6b3
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 23:02:28 2023 +0000

    Update devcontainer-smoketest.yaml

    Comment out most src

commit 1df7c4a
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 23:00:45 2023 +0000

    Update devcontainer-smoketest.yaml

    Fix spacing?

commit 8b137be
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 22:52:54 2023 +0000

    Update devcontainer-smoketest.yaml

    Comment out faulty line for test

commit 9893862
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 22:51:15 2023 +0000

    Update devcontainer-smoketest.yaml

commit 3d06456
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 22:48:25 2023 +0000

    Update devcontainer-smoketest.yaml

commit 73a9fc5
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 22:40:29 2023 +0000

    Rename devcontainer-smoketest to devcontainer-smoketest.yaml

commit 7dc150e
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 22:38:30 2023 +0000

    Create devcontainer-smoketest

    Runs on PR's

commit df1c83c
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 22:11:47 2023 +0000

    Update Dockerfile.ESP32

commit cc7fc3c
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 22:10:42 2023 +0000

    Update Dockerfile.ESP32

    Use Python image rather than custom repo

commit 036fae8
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 21:27:30 2023 +0000

    Update Dockerfile.All

    Fix duplicate clone

commit d21cd22
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 20:40:37 2023 +0000

    Update Dockerfile.TI

commit 35cd19e
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 20:40:21 2023 +0000

    Update Dockerfile.ChibiOS

commit 5332118
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 20:40:04 2023 +0000

    Update Dockerfile.AzureRTOS

commit 1283bf3
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 20:39:47 2023 +0000

    Update Dockerfile.All

commit 8a08bd1
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 20:32:27 2023 +0000

    Update Dockerfile.TI

commit 01e06ab
Merge: 444d9fd 5e3d68e
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 20:30:28 2023 +0000

    Merge branch 'main' into devcontainer-superficial

commit 444d9fd
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 20:29:03 2023 +0000

    Update Dockerfile.ChibiOS

commit dc222bb
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 20:27:33 2023 +0000

    Update Dockerfile.AzureRTOS

commit d96a4cb
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 20:26:26 2023 +0000

    Update Dockerfile.AzureRTOS

commit b2a2c65
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Fri Nov 10 20:07:59 2023 +0000

    Update Dockerfile.All

commit 5e3d68e
Author: Cory Charlton <CoryCharlton@users.noreply.github.com>
Date:   Fri Nov 10 11:43:47 2023 -0800

    Adding check for zero length string (nanoframework#2826)

commit 12cf52f
Author: José Simões <jose.simoes@eclo.solutions>
Date:   Fri Nov 10 18:29:29 2023 +0000

    Code style fixes

    ***NO_CI***

commit bec9709
Author: José Simões <jose.simoes@eclo.solutions>
Date:   Fri Nov 10 18:12:22 2023 +0000

    Fix block storage config for ST_NUCLEO64_F091RC

    ***NO_CI***

commit 365df84
Author: José Simões <jose.simoes@eclo.solutions>
Date:   Fri Nov 10 13:33:14 2023 +0000

    Bump version to 1.9.0

commit 18c385b
Author: Cory Charlton <CoryCharlton@users.noreply.github.com>
Date:   Wed Nov 8 18:58:34 2023 -0800

    Switching MathInternal.Min/Max to managed implementations (nanoframework#2815)

commit ac97f68
Author: Cory Charlton <CoryCharlton@users.noreply.github.com>
Date:   Wed Nov 8 18:57:45 2023 -0800

    Improve min max performance and IEEE compliance (nanoframework#2810)

    ***NO_CI***

commit 93438ee
Author: Cory Charlton <CoryCharlton@users.noreply.github.com>
Date:   Wed Nov 8 18:40:39 2023 -0800

    Update `System.IO.File` declaration (nanoframework#2823)

    ***NO_CI***

commit 7e3a2a9
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Thu Nov 9 00:04:50 2023 +0000

    Update Dockerfile.ChibiOS

    Fix issue with gcc location

commit b693206
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Wed Nov 8 23:21:08 2023 +0000

    Update Dockerfile.ChibiOS

commit 278935d
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Wed Nov 8 22:19:35 2023 +0000

    Update Dockerfile.All

commit 5ef9674
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Wed Nov 8 22:19:11 2023 +0000

    Update Dockerfile.ChibiOS

commit 99e7070
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Wed Nov 8 22:18:41 2023 +0000

    Update Dockerfile.AzureRTOS

    Fix hex2dfu

commit a52d6c6
Author: Robin Jones <networkfusion@users.noreply.github.com>
Date:   Wed Nov 8 20:50:23 2023 +0000

    Improve dockerfiles

    Superficial changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes left review comments

Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: bug Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Math.Min(double/float) do not handle NaN correctly Math.Max(float) and Math.Min(float) are 3x slower than the double overloads
3 participants
@CoryCharlton @josesimoes @nfbot