Adjust DTO accessors to make them public

[torbacz]

Description

Motivation and Context

• Resolves Unable to use JSON converters due to encapsulation Home#1183

How Has This Been Tested?

• Local build + pipeline (does not require more testing in my opinion)

Screenshots

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue with code or algorithm)
• New feature (non-breaking change which adds functionality to code)
• Breaking change (fix or feature that would cause existing functionality to change)
• Config and build (change in the configuration and build system, has no impact on code or features)
• Dependencies (update dependencies and changes associated, has no impact on code or features)
• Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
• Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

• My code follows the code style of this project (only if there are changes in source code).
• My changes require an update to the documentation (there are changes that require the docs website to be updated).
• I have updated the documentation accordingly (the changes require an update on the docs in this repo).
• I have read the CONTRIBUTING document.
• I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
• I have added new tests to cover my changes.

[Ellerbach]

Thanks, looks good to me! Sealed is a good choice for the classes as they should not be inherited or extended. @josesimoes for a quick look as it's a sensitive nuget :-)

[torbacz]

I've also remove some parameterless constructors. The logic behind was simple - previously they were internal without any references. Now, because we are going with "public" let's clean it to keep public API minimal as possible.

[josesimoes]

I think we're good now!
Thank you for another improvement. 👍🏻

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication