Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Device Provisioning Service in Azure IoT SDK #3

Merged
merged 1 commit into from
Aug 1, 2021
Merged

Conversation

Ellerbach
Copy link
Member

Description

Adding Device Provisioning Service in Azure IoT SDK

Motivation and Context

  • Adding Device Provisioning Service in Azure IoT SDK
  • Improving current SDK for closing and disposing properly the mqqt client
  • Documentation added in the main README.md
  • Samples to be added once PR approved and merged

How Has This Been Tested?

Thru real device on an ESP32 with the code provided in th README.md file

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added Type: bug Something isn't working Type: enhancement New feature or request labels Jul 29, 2021
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Clean and simple as we like it. 👍👏

@Ellerbach Ellerbach merged commit b090cad into develop Aug 1, 2021
@Ellerbach Ellerbach deleted the add-dps branch January 12, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working Type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants