Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change nannou-new to use installed instance of cargo rather than the cargo crate #606

Open
mitchmindtree opened this issue May 15, 2020 · 2 comments
Labels
bug user experience Anything that affects how users interact with the framework

Comments

@mitchmindtree
Copy link
Member

This would greatly improve nannou-new compile times and also avoid an issue that sometimes occurs where the package needs to be built twice as a result of the separate cargos (the first build by the cargo dep, the second in the user's environment).

It would be nice to address this before #604.

@mitchmindtree mitchmindtree added bug user experience Anything that affects how users interact with the framework labels May 15, 2020
@kneitinger
Copy link
Contributor

Hi @mitchmindtree I'm beginning to work on this (as well as #448), and have one clarifying question. Is the point of this task to call the cargo as a std::process::Command, or to somehow use a system-wide copy of the cargo crate? Nothing in my investigation was able to suggest that the latter is something that exists, so I just wanted to verify that a Command based approach was intended before embarking on that. Thanks!

@mitchmindtree
Copy link
Member Author

Hi @kneitinger!

Is the point of this task to call the cargo as a std::process::Command, or to somehow use a system-wide copy of the cargo crate?

Yes, kind of both. Like you, I was unable to find a nice library for using the user's pre-installed cargo instance from a library in a nice manner, but for such a small task I agree using Command is probably easiest :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug user experience Anything that affects how users interact with the framework
Projects
None yet
Development

No branches or pull requests

2 participants