[SOLVED] Context menu crashes app when wrapping a navigation trigger

[peterferguson]

Hey first off thanks for the library!

On "zeego": "^1.7.0" I have noticed an issue where if you try to cancel opening the context menu just before it should open then you get the navigation & the menu opens then app crashes.

I pulled the code from the example and wrapped my ConversationPreview component with no changes. The component is pretty simple, just a Pressable with an expo-router router.push.

This is using "expo": "^49.0.9" in a dev client & "expo-router": "2.0.4".

If you can't replicate let me know and I can try create a repo.

Not a big enough issue to commit time to rn but thought I would let you know

Untitled.mov

[nandorojo]

ah that’s not good! i’m working through some other issues with the menu but i’ll try to address this if the reason becomes apparent. it’s hard coordinating with native view controllers for these edge cases

[peterferguson]

Found this on issue that solves the problem

dominicstop/react-native-ios-context-menu#9 (comment)

Maybe for zeego is it just better to have this documented somewhere?

A FAQ or common pitfalls section?

I will leave it up to you whether to close or not (might be worth leaving open if you are open to the docs changes?)

[nandorojo]

Oh yeah that does make sense. I wonder if we should make it the default behavior or not. Or I also wonder if there is a way to fix this upstream entirely.

[peterferguson]

Seems like it could be simple enough to check if the child passed to the trigger has onLongPress set and if not override it.

Also a reasonably small change that (on first glance) shouldn't have many repercussions in other trigger use-cases.

[nandorojo]

The issue is, the child of the context menu could be anywhere (as in multiple children down).

So if a nested child is the pressable, it won't get auto-fixed.

[nandorojo]

@peterferguson this is getting fixed upstream in the context menu v2:

dominicstop/react-native-ios-context-menu#77 (comment)

[sidorchukandrew]

This seems to still be happening on the latest version of zeego (1.7.2) and react-native-ios-context-menu (2.3.0). Is it possible that zeego needs to set shouldPreventLongPressGestureFromPropagating on the ContextMenuView? It looks like it's a new prop (I don't know much Swift but it also looks like the default value is getting set to true)

[nandorojo]

Hmm good to know

[nandorojo]

@sidorchukandrew you can now pass __unsafeIosProps to Zeego's ContextMenu to test this. It'll forward props down

[sidorchukandrew]

I'll get that tested shortly!

[sidorchukandrew]

@nandorojo Is there a new release I should install?