feat: ✨ add chromeapp variable for Windows script

nanasess · Nov 24, 2024 · dc294c4 · dc294c4
1 parent ec367c5
commit dc294c4
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/lib/setup-chromedriver.ps1 b/lib/setup-chromedriver.ps1
@@ -1,9 +1,15 @@
 Param(
-    [string]$version
+    [string]$version,
+    [string]$chromeapp
 )
 
+if([string]::IsNullOrEmpty($chromeapp))
+{
+    $chromeapp = "C:\Program Files\Google\Chrome\Application\chrome.exe"
+}
+
 $json_url = "https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json"
-$chrome_fullversion = (Get-Item "C:\Program Files\Google\Chrome\Application\chrome.exe").VersionInfo.FileVersion
+$chrome_fullversion = (Get-Item $chromeapp).VersionInfo.FileVersion
 
 Write-Output "Chrome version: $chrome_fullversion"
 if([string]::IsNullOrEmpty($version))

diff --git a/src/setup-chromedriver.ts b/src/setup-chromedriver.ts
@@ -22,9 +22,10 @@ async function run() {
     }
     if (arch == "win32") {
       await exec.exec(
-        "powershell -File " +
-          path.join(__dirname, "../lib", "setup-chromedriver.ps1 " + version),
-      );
+        "powershell -File " + path.join(__dirname, "../lib", "setup-chromedriver.ps1 "), [
+        version,
+        chromeapp
+      ]);
     } else {
       await exec.exec(path.join(__dirname, "../lib", "setup-chromedriver.sh"), [
         version,