symbol: Fix uninitialized 'sec_iter' in the 'arch_load_dynsymtab_noplt' #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `struct uftrace_elf_iter sec_iter` is being used without initialization, and only specific values are being copied. This can lead to unexpected behavior in the copied other iters. SUMMARY: MemorySanitizer: use-of-uninitialized-value arch/x86_64/symbol.c:33:14 in arch_load_dynsymtab_noplt Exiting ==2474640==WARNING: MemorySanitizer: use-of-uninitialized-value ==2474525==WARNING: MemorySanitizer: use-of-uninitialized-value ==2474780==WARNING: MemorySanitizer: use-of-uninitialized-value 0 0x55985b0a1f46 in arch_load_dynsymtab_noplt arch/x86_64/symbol.c:33 1 0x55985b0792f7 in load_dynsymtab utils/symbol.c:726:2 2 0x55985b05bb30 in load_module_symbol utils/symbol.c:1111:2 3 0x55985b05a3fe in load_module_symtab utils/symbol.c:1144:2 4 0x55985b05db5f in load_module_symtabs utils/symbol.c:1220:14 5 0x55985adb5b34 in load_session_symbols cmds/record.c:1482:3 6 0x55985ada6e0e in write_symbol_files cmds/record.c:2036:2 7 0x55985ad923d1 in do_main_loop cmds/record.c:2142:2 8 0x55985ad8ce9a in command_record cmds/record.c:2311:9 9 0x55985acf190a in main uftrace.c:1534:9 Signed-off-by: Yunseong Kim <yskelg@gmail.com>
namhyung
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
struct uftrace_elf_iter sec_iteris being used without initialization, and only specific values are being copied. This can lead to unexpected behavior in the copied other iters.