handle 'exit' message #50
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least with the helix editor, prior to this change, golangci-lint-langserver will handle the 'shutdown' message, but will then stall, waiting for the invoking client (helix) to terminate the LSP process, while helix is waiting for the LSP process to self-terminate upon receiving the 'exit' message. Eventually, helix will terminate the LSP process after a ~10 second grace period has passed, though this is rather annoying to wait for. With the change, the 'exit' command will cause the jsonrpc2 connection to close, which in turn will lead to the LSP process exiting quickly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least with the helix editor, prior to this change,
golangci-lint-langserver will handle the 'shutdown' message,
but will then stall, waiting for the invoking client (helix)
to terminate the LSP process, while helix is waiting for the LSP process
to self-terminate upon receiving the 'exit' message.
Eventually, helix will terminate the LSP process
after a ~10 second grace period has passed,
though this is rather annoying to wait for.
With the change, the 'exit' command will cause
the jsonrpc2 connection to close,
which in turn will lead to the LSP process exiting quickly.