This repository was archived by the owner on Jun 29, 2020. It is now read-only.
Fix bug that leads to no output when PUPPETEER_PDF_CMD_OPTIONS is configured #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
PUPPETEER_PDF_CMD_OPTIONS
is configured in the Django settings without a'path'
key, then no--path
argument is passed to puppeteer-pdf. In that case, an empty response is returned. It seems like one should be able to configured options without specifying a specific path to use every time, so I fixed it to always include a path key. Let me know if that seems reasonable.