Skip to content

Commit

Permalink
Refine Entire Platform To Support Uninspected Names in NameGuard (#350)
Browse files Browse the repository at this point in the history
* Add support for Uninspected Names in NameGuard UI

---------

Co-authored-by: lightwalker.eth <126201998+lightwalker-eth@users.noreply.github.com>
  • Loading branch information
notrab and lightwalker-eth authored Aug 26, 2024
1 parent cd3b936 commit 39ece2a
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 14 deletions.
5 changes: 5 additions & 0 deletions .changeset/thin-eels-burn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@namehash/nameguard-react": patch
---

Add support for uninspected NameGuard reports.
8 changes: 4 additions & 4 deletions packages/nameguard-react/src/components/Report/LabelList.tsx
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
import React from "react";
import type { NameGuardReport } from "@namehash/nameguard";
import type { LabelGuardReport } from "@namehash/nameguard";

import { LabelListItem } from "./LabelListItem";

type LabelListProps = {
items?: NameGuardReport["labels"];
items: LabelGuardReport[];
};

export function LabelList({ items = [] }: LabelListProps) {
const rawLabels = items.map((i) => i.label) ?? [];
const rawLabels = items.map((i) => i.label);

return items?.map((label, index) => (
return items.map((label, index) => (
<LabelListItem
key={index}
index={index}
Expand Down
21 changes: 12 additions & 9 deletions packages/nameguard-react/src/components/Report/Report.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,12 @@ export const Report = ({
<ExternalLinks title="View name in" links={externalLinks} />
</div>
</div>

{isLoading && !hadLoadingError && normalizationUnknown && (
<LoadingSkeleton parsedName={parsedName} />
)}
{isLoading && !hadLoadingError && !normalizationUnknown && (
<LoadingSkeleton parsedName={parsedName} />
)}

{hadLoadingError && <ReportError />}

{data && (
Expand All @@ -145,14 +143,19 @@ export const Report = ({
))}
</div>
</div>
<div className="space-y-4 md:space-y-5">
<p className="text-black font-semibold text-lg leading-6">
Name inspection
</p>

<LabelList items={data.labels} />
</div>
</Fragment>
)}
{data && data.inspected && (
<div className="space-y-4 md:space-y-5">
<p className="text-black font-semibold text-lg leading-6">
Name inspection
</p>

<LabelList items={data.labels} />
</div>
)}
{data && (
<Fragment>
<FeedbackNotice onChatClick={openChatModal} />
<ReportFooter />
</Fragment>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ const examples = [
"unknоwn.eth",
"john🇺🇸",
"7️⃣7️⃣7️⃣.eth",
"extremelylongnamethatgoesonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandonandon.eth",
].map((name) => buildENSName(name));

export const SearchEmptyState = () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function Tooltip({
placement = "top",

/*
Props are applied to the Float component,
Props are applied to the Float component,
which is a wrapper for the tooltip "children".
*/
...props
Expand Down

0 comments on commit 39ece2a

Please sign in to comment.